Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add mapTraceFetchClientState #5025

Merged
merged 1 commit into from
Jan 6, 2025
Merged

add mapTraceFetchClientState #5025

merged 1 commit into from
Jan 6, 2025

Conversation

nfrisby
Copy link
Contributor

@nfrisby nfrisby commented Dec 13, 2024 •
edited by coot
Loading

Description

Merely adding

mapTraceFetchClientState ::
     (HeaderHash h1 ~ HeaderHash h2, HasHeader h2)
  => (h1 -> h2) -> TraceFetchClientState h1 -> TraceFetchClientState h2

A Consensus PR I'm working on passes in an annotated header to BlockFetch, but I'd like to (at least for now) hide that fact from the downstream tracers. So I need to discard that annotation data from the content of this tracer event, which this function makes possible.

Checklist

Quality

  • Commit sequence makes sense and have useful messages, see ref.
  • New tests are added and existing tests are updated.
  • Self-reviewed the PR.

Maintenance

  • Linked an issue or added the PR to the current sprint of ouroboros-network project.
  • Added labels.
  • Updated changelog files.
  • The documentation has been properly updated, see ref.

@nfrisby nfrisby requested a review from a team as a code owner December 13, 2024 14:32
@nfrisby nfrisby mentioned this pull request Dec 13, 2024
Open
@nfrisby nfrisby force-pushed the nfrisby/mapTraceFetchClientState branch 4 times, most recently from 33eab6d to 381a0c7 Compare December 17, 2024 16:59
@nfrisby nfrisby added the block-fetch Issues related to block fetch component. label Dec 18, 2024
coot
coot approved these changes Dec 23, 2024
View reviewed changes
Copy link
Contributor

@coot coot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nfrisby nfrisby force-pushed the nfrisby/mapTraceFetchClientState branch from 381a0c7 to 91d326b Compare January 6, 2025 17:40
@nfrisby nfrisby enabled auto-merge January 6, 2025 17:40
@nfrisby nfrisby force-pushed the nfrisby/mapTraceFetchClientState branch from 91d326b to db2114a Compare January 6, 2025 17:40
@nfrisby
Copy link
Contributor Author

nfrisby commented Jan 6, 2025

I rebased (with signature!). There were no conflicts, so I clicked Merge when Ready. Thanks for the review.

@nfrisby nfrisby added this pull request to the merge queue Jan 6, 2025
Merged via the queue into main with commit 08e7e31 Jan 6, 2025
130 of 141 checks passed
@nfrisby nfrisby deleted the nfrisby/mapTraceFetchClientState branch January 6, 2025 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coot coot coot approved these changes

Assignees

@nfrisby nfrisby

Labels
block-fetch Issues related to block fetch component.
Projects
Ouroboros Network
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nfrisby @coot