Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate the Conway era #3962

Closed
jasagredo opened this issue Aug 17, 2022 · 2 comments · Fixed by #3971
Closed

Integrate the Conway era #3962

jasagredo opened this issue Aug 17, 2022 · 2 comments · Fixed by #3971
Assignees
@nfrisby
Labels
consensus issues related to ouroboros-consensus conway Conway era + chang hard fork

Comments

@jasagredo
Copy link
Contributor

No description provided.

@jasagredo jasagredo added the conway Conway era + chang hard fork label Aug 17, 2022
@nfrisby
Copy link
Contributor

nfrisby commented Aug 17, 2022

Ledger Team has said we should start integrating Conway now. Because it's urgent, I'm going to try to bang it out myself, instead of leveraging it as an onboarding opportunity (as we did with Pawel for Alonzo).

Some notes:

  • I approved PR Account for new ledger refactor. #3933, with some minor caveats. The upstream Conway branch will depend on that.
  • That upstream branch is currently labeled release/1.1.0 but Jared may be renaming it soon to release/1.1.x and then each concrete release 1.1.0, 1.1.1, etc would be a git tag.

This should be the simplest era integration yet. Therefore, once we've unblocked node, I might suggest each of the team members try to re-create the integration themselves, without looking at my code, as an onboarding exercise so people are exposed to what "adding an era" looks like.

@nfrisby nfrisby mentioned this issue Aug 21, 2022
Merged
9 tasks
@jasagredo jasagredo moved this from 🔖 Ready to 🏗 In progress in Consensus Team Backlog Aug 23, 2022
@dnadales dnadales moved this from 🏗 In progress to 🔖 Ready in Consensus Team Backlog Sep 20, 2022
@nfrisby
Copy link
Contributor

nfrisby commented Sep 20, 2022

Also see: https://github.com/input-output-hk/ouroboros-network/blob/master/ouroboros-consensus/docs/AddingAnEra.md

iohk-bors bot added a commit that referenced this issue Feb 1, 2023
@iohk-bors @nfrisby
Merge #3971
41cdb42 
3971: Integrate the Conway era r=dnadales a=nfrisby

Fixes #3962. Integrates the Conway era.



Co-authored-by: Nicolas Frisby <[email protected]>
@iohk-bors iohk-bors bot closed this as completed in 6085c03 Feb 1, 2023
@github-project-automation github-project-automation bot moved this from 🔖 Ready to ✅ Done in Consensus Team Backlog Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nfrisby nfrisby

Labels
consensus issues related to ouroboros-consensus conway Conway era + chang hard fork
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Integrate the Conway era IntersectMBO/ouroboros-network
2 participants
@nfrisby @jasagredo