Expose over-the-wire encoded transaction size #1211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crocodile-dentist
requested review from
nfrisby,
jasagredo,
amesgen,
fraser-iohk,
dnadales and
RenateEilers
as code owners
crocodile-dentist
force-pushed
the
mwojtowicz/tx-wire-size
branch
2 times, most recently
from
65bfb2e to
a26a963
Compare
jasagredo
reviewed
Aug 9, 2024
ouroboros-consensus-diffusion/changelog.d/20240808_125632_marcin.wojtowicz_tx_wire_size.md
Outdated
Show resolved
Hide resolved
ouroboros-consensus/changelog.d/20240808_101916_marcin.wojtowicz_tx_wire_size.md
Outdated
Show resolved
Hide resolved
crocodile-dentist
force-pushed
the
mwojtowicz/tx-wire-size
branch
from
a26a963 to
2d9433b
Compare
7 tasks
crocodile-dentist
force-pushed
the
mwojtowicz/tx-wire-size
branch
from
2d9433b to
53a5d0d
Compare
crocodile-dentist
changed the base branch from
main
to
bolt12/tx-submission
crocodile-dentist
force-pushed
the
mwojtowicz/tx-wire-size
branch
from
53a5d0d to
db1f76b
Compare
The new method leverages a corresponding method recently exposed by ledger side to provide encoded transaction sizes to eg. diffusion layer.
crocodile-dentist
force-pushed
the
mwojtowicz/tx-wire-size
branch
from
db1f76b to
d2e7058
Compare
crocodile-dentist
added a commit
that referenced
this pull request
Sep 24, 2024
# Description This change introduces a new method wireSizeTx for the LedgerSupportsMempool class. It provides actual CBOR encoded transaction size as it is when transmitted over the network, which the difffusion layer could exploit. Also note that: - New code should be properly tested (even if it does not add new features). - The fix for a regression should include a test that reproduces said regression. IntersectMBO/cardano-ledger#4521 IntersectMBO/ouroboros-network#4926
crocodile-dentist
added a commit
that referenced
this pull request
Sep 24, 2024
# Description This change introduces a new method wireSizeTx for the LedgerSupportsMempool class. It provides actual CBOR encoded transaction size as it is when transmitted over the network, which the difffusion layer could exploit. Also note that: - New code should be properly tested (even if it does not add new features). - The fix for a regression should include a test that reproduces said regression. IntersectMBO/cardano-ledger#4521 IntersectMBO/ouroboros-network#4926
crocodile-dentist
added a commit
that referenced
this pull request
Sep 24, 2024
# Description This change introduces a new method wireSizeTx for the LedgerSupportsMempool class. It provides actual CBOR encoded transaction size as it is when transmitted over the network, which the difffusion layer could exploit. Also note that: - New code should be properly tested (even if it does not add new features). - The fix for a regression should include a test that reproduces said regression. IntersectMBO/cardano-ledger#4521 IntersectMBO/ouroboros-network#4926
crocodile-dentist
added a commit
that referenced
this pull request
Sep 24, 2024
# Description This change introduces a new method wireSizeTx for the LedgerSupportsMempool class. It provides actual CBOR encoded transaction size as it is when transmitted over the network, which the difffusion layer could exploit. Also note that: - New code should be properly tested (even if it does not add new features). - The fix for a regression should include a test that reproduces said regression. IntersectMBO/cardano-ledger#4521 IntersectMBO/ouroboros-network#4926
crocodile-dentist
added a commit
that referenced
this pull request
Sep 24, 2024
# Description This change introduces a new method wireSizeTx for the LedgerSupportsMempool class. It provides actual CBOR encoded transaction size as it is when transmitted over the network, which the difffusion layer could exploit. Also note that: - New code should be properly tested (even if it does not add new features). - The fix for a regression should include a test that reproduces said regression. IntersectMBO/cardano-ledger#4521 IntersectMBO/ouroboros-network#4926
crocodile-dentist
added a commit
that referenced
this pull request
Sep 24, 2024
# Description This change introduces a new method wireSizeTx for the LedgerSupportsMempool class. It provides actual CBOR encoded transaction size as it is when transmitted over the network, which the difffusion layer could exploit. Also note that: - New code should be properly tested (even if it does not add new features). - The fix for a regression should include a test that reproduces said regression. IntersectMBO/cardano-ledger#4521 IntersectMBO/ouroboros-network#4926
crocodile-dentist
added a commit
that referenced
this pull request
Sep 24, 2024
# Description This change introduces a new method wireSizeTx for the LedgerSupportsMempool class. It provides actual CBOR encoded transaction size as it is when transmitted over the network, which the difffusion layer could exploit. Also note that: - New code should be properly tested (even if it does not add new features). - The fix for a regression should include a test that reproduces said regression. IntersectMBO/cardano-ledger#4521 IntersectMBO/ouroboros-network#4926
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change introduces a new method wireSizeTx for the LedgerSupportsMempool class. It provides actual CBOR encoded transaction size as it is when transmitted over the network, which the difffusion layer could exploit.
Also note that:
IntersectMBO/cardano-ledger#4521
IntersectMBO/ouroboros-network#4926