Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHaP bump for node 10.1.3 #6043

Merged
merged 1 commit into from
Nov 27, 2024
Merged

Conversation

crocodile-dentist
Copy link
Contributor

Description

bump CHaP for node 10.1.3 release.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • roundtrip tests
    • integration tests
      See Runnings tests for more details
  • Any changes are noted in the CHANGELOG.md for affected package
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • Self-reviewed the diff

Note on CI

If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.

@crocodile-dentist crocodile-dentist requested review from a team as code owners November 26, 2024 18:32
@crocodile-dentist crocodile-dentist self-assigned this Nov 26, 2024
Copy link
Contributor

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should read

                      , cardano-ledger-conway ^>= 1.17.3

, cardano-ledger-conway ^>= 1.17.2

@crocodile-dentist
Copy link
Contributor Author

crocodile-dentist commented Nov 27, 2024

@lehins It is - this is a branch release and the change doesn't show up in this diff as it is present on the prior/base commit on release/10.1.3.

@crocodile-dentist crocodile-dentist requested a review from a team as a code owner November 27, 2024 08:22
@crocodile-dentist crocodile-dentist merged commit 36871ba into release/10.1.3 Nov 27, 2024
22 of 23 checks passed
@crocodile-dentist crocodile-dentist deleted the mwojtowicz/10.1.3 branch November 27, 2024 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants