Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bench: improve genesis cache retrieval; maintenance for locli and others #6041

Merged
merged 7 commits into from
Nov 22, 2024

Conversation

mgmeier
Copy link
Contributor

@mgmeier mgmeier commented Nov 21, 2024

Description

This PR improves retrieval of huge staked geneses from the workbench cache: small parameter changes shouldn't trigger (lengthy) recreation of a genesis, but can be patched into a retrieved cache hit if they're unrelated to staking itself.

Furthermore, there are various changes to locli, including proper handling of Plutus RIPEMD-160 workloads in reporting - and lots of cleanup. Please see locli's brand new changelog for more details.

Then, there's a fix for the Mempool.Synced tracer that lacked a proper namespace.

Last not least, several maintenance updates for Nomad healthcheck, workbench console output and adjustments of the scripts/lite/ to recent P2P.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • roundtrip tests
    • integration tests
      See Runnings tests for more details
  • Any changes are noted in the CHANGELOG.md for affected package
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • Self-reviewed the diff

@mgmeier mgmeier marked this pull request as ready for review November 21, 2024 19:25
@mgmeier mgmeier requested review from a team as code owners November 21, 2024 19:25
Copy link
Contributor

@fmaste fmaste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mgmeier mgmeier added this pull request to the merge queue Nov 22, 2024
Merged via the queue into master with commit e37615c Nov 22, 2024
24 checks passed
@mgmeier mgmeier deleted the bench-master branch November 22, 2024 08:34
@@ -355,8 +355,8 @@ let
else
local tip block slot
# Returns nothing/empty/"" when the node is exiting
tip=$(${cardano-cli}/bin/cardano-cli query tip \
--testnet-magic "''${network_magic}" \
tip=$(${cardano-cli}/bin/cardano-cli conway query tip \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd be worried about hard-coding Conway here..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants