Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cardano-testnet | Add correct contents for proposal anchor and constitution #6037

Conversation

carbolymer
Copy link
Contributor

@carbolymer carbolymer commented Nov 18, 2024

Description

Adds correct contents for proposal anchor and the constitution located at urls used in tests.

Otherwise, those tests will fail with cardano-cli 10.1.1.0.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • roundtrip tests
    • integration tests
      See Runnings tests for more details
  • Any changes are noted in the CHANGELOG.md for affected package
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • Self-reviewed the diff

Note on CI

If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.

@carbolymer carbolymer requested review from a team as code owners November 18, 2024 18:37
Copy link
Contributor

@erikd erikd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@Jimbo4350 Jimbo4350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not define a value in Testnet.Defaults ?

@carbolymer
Copy link
Contributor Author

@Jimbo4350 because someone posted the constitution file without EOL at the end of file under that URL. I've spent 30 minutes trying to inline it to Testnet.Defaults without success - Haskell (even using ByteString) somehow always puts EOL when writing to a file, which results in a hash mismatch.

I've also wasted time looking for a hash mismatch in a proposal anchor because of trailing whitespaces there. 😠

@carbolymer carbolymer added this pull request to the merge queue Nov 18, 2024
Merged via the queue into master with commit 6e969c6 Nov 18, 2024
23 checks passed
@carbolymer carbolymer deleted the mgalazyn/fix/add-correct-contents-for-proposal-anchor-constutituion branch November 18, 2024 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants