Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add supplemental datum plutus test #6025

Merged
merged 2 commits into from
Oct 29, 2024

Conversation

Jimbo4350
Copy link
Contributor

@Jimbo4350 Jimbo4350 commented Oct 28, 2024

Description

  • Implement a plutus script that checks for a specific datum in the tx
  • This datum has been included in the tx as a supplemental datum in the hprop_plutus_v3 test via the cardano-cli option --tx-out-datum-embed-file.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • roundtrip tests
    • integration tests
      See Runnings tests for more details
  • Any changes are noted in the CHANGELOG.md for affected package
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • Self-reviewed the diff

Note on CI

If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.

This script checks for the presence of a particular datum in the tx
@Jimbo4350 Jimbo4350 requested review from a team as code owners October 28, 2024 17:53
Add plutusV3SupplementalDatumScript script value
@Jimbo4350 Jimbo4350 force-pushed the jordan/add-supplemental-datum-plutus-test branch from c7ce3f5 to c0c8a34 Compare October 28, 2024 18:00
@@ -543,3 +544,9 @@ defaultUtxoKeys n =
plutusV3Script :: Text
plutusV3Script =
"{ \"type\": \"PlutusScriptV3\", \"description\": \"\", \"cborHex\": \"46450101002499\" }"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A comment explaining how this was generated here, would be great.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to add this process to the documentation and then link to it. @CarlosLopezDeLara where should this documentation go?

@Jimbo4350 Jimbo4350 merged commit 02cd604 into master Oct 29, 2024
23 of 24 checks passed
@Jimbo4350 Jimbo4350 deleted the jordan/add-supplemental-datum-plutus-test branch October 29, 2024 13:16
@Jimbo4350 Jimbo4350 restored the jordan/add-supplemental-datum-plutus-test branch October 29, 2024 13:16
@Jimbo4350 Jimbo4350 deleted the jordan/add-supplemental-datum-plutus-test branch October 29, 2024 13:16
Copy link

@Sultan05500 Sultan05500 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finished

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants