Update dependencies #2149
Merged
Update dependencies #2149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrBliss
commented
Dec 1, 2020
| @@ -182,7 +182,6 @@ constraints: | |||
| -- systemd-2.3.0 requires at least network 3.1.1.0 but it doesn't declare | |||
| -- that dependency | |||
| , network >= 3.1.1.0 | |||
| , streaming-bytestring < 0.1.7 | |||
Comment on lines
161
to
174
| -- TODO: Could not deduce: Cardano.Ledger.Core.Metadata ledgerera ~ Shelley.MetaData | ||
| -- | ||
| -- The ledger has turned Metadata in a type family. | ||
| -- 'TxMetadata' is a newtype around 'Shelley.MetaData', which is what the type | ||
| -- family instance Core.Metadata (ShelleyEra c) will reduce to. | ||
| -- | ||
| -- The result type of this function is parametric in @ledgerera@ (btw, why not | ||
| -- @ledgerEra@? @ledgerera@ is confusing to read and write), while the | ||
| -- 'TxMetadata' is specific to the Shelley era. This can no longer remain the | ||
| -- case. Either the result type must be fixed to the Shelley era or the | ||
| -- 'TxMetadata' type must be generalised to any era (the right thing to do IMO). | ||
| toShelleyMetadataHash :: () -- TODO Shelley.ValidateMetadata ledgerera | ||
| => TxMetadata -> Shelley.MetaDataHash ledgerera | ||
| toShelleyMetadataHash (TxMetadataShelley m) = Shelley.hashMetaData m | ||
| toShelleyMetadataHash = undefined -- (TxMetadataShelley m) = Shelley.hashMetadata m |
There was a problem hiding this comment.
Can somebody from the node cli team take care of this? There are more type errors because of this change.
dcoutts
force-pushed
the
mrBliss/update-dependencies-20201201
branch
from
d882f3a to
e1178ac
Compare
dcoutts
approved these changes
Dec 1, 2020
mrBliss
commented
Dec 1, 2020
dcoutts
force-pushed
the
mrBliss/update-dependencies-20201201
branch
from
2779d9e to
a6829f3
Compare
|
bors merge |
iohk-bors bot
added a commit
that referenced
this pull request
Dec 1, 2020
2149: Update dependencies r=dcoutts a=mrBliss Visible changes: * IntersectMBO/cardano-ledger#1993 * IntersectMBO/cardano-ledger#2021 Co-authored-by: Thomas Winant <[email protected]>
intricate
approved these changes
Dec 1, 2020
|
Build failed: |
intricate
force-pushed
the
mrBliss/update-dependencies-20201201
branch
from
a2742cd to
31e4fe4
Compare
dcoutts
approved these changes
Dec 1, 2020
Visible changes: * IntersectMBO/cardano-ledger#1993 * IntersectMBO/cardano-ledger#2021 One of the changes in Allegra over Shelley is the notion of transaction auxiliary data. We retrospectively define tx metadata to be part of the auxiliary data where in the Shelley era this consists only of the existing tx metadata. But from the Allegra era the auxiliary data contains both the tx metadata and also auxiliary scripts. So where we previously hashed the tx metadata, we now hash the auxiliary data. Take the opportunity to refactor the tx metadata representation and conversion functions to fit better with the new scheme. Also take the opportunity to tidy up the imports in the Query module since we have some very similarly-named type classes. Co-authored-by: Duncan Coutts <[email protected]>
Doing a number of TODOs. The tests were generating invalid tx bodies, e.g. with negative tx outs, which ought to be caught by the validation in the API rather than in the ledger serialisation. This does not yet adjust the generators to make only valid tx bodies.
dcoutts
force-pushed
the
mrBliss/update-dependencies-20201201
branch
from
31e4fe4 to
52092c9
Compare
|
bors merge |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Visible changes:
Cardano.Ledger.ShelleyandShelleyMAera modules cardano-ledger#2021