Windows builds #1884
Closed
Windows builds #1884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
newhoggy
requested review from
dcoutts,
erikd,
intricate,
Jimbo4350 and
mrBliss
as code owners
newhoggy
force-pushed
the
windows-builds
branch
20 times, most recently
from
59c43a2 to
db91b0c
Compare
newhoggy
force-pushed
the
windows-builds
branch
from
e4af9f2 to
528a5be
Compare
coot
reviewed
Sep 30, 2020
| - uses: actions/checkout@v1 | ||
|
|
||
| - name: Install pkgconfiglite | ||
| if: matrix.os == 'windows-latest' |
There was a problem hiding this comment.
Ach, that's the trick to run a step on a given platform, I was missing it somewhere else :)
coot
reviewed
Sep 30, 2020
.github/workflows/haskell.yml
Outdated
| run: cabal update | ||
|
|
||
| - name: Select build directory | ||
| run: echo "::set-env name=CABAL_BUILDDIR::dist" |
There was a problem hiding this comment.
Will this pick the current directory? On windows I had problems with length of paths names, so I always build somewhere very close to the root, e.g. C://d.
There was a problem hiding this comment.
So far this has been working. Shortening the dist-newstyle to dist was just enough to squeeze in under the path name limit.
newhoggy
force-pushed
the
windows-builds
branch
2 times, most recently
from
4816378 to
0d53ec0
Compare
newhoggy
force-pushed
the
windows-builds
branch
14 times, most recently
from
01a605d to
51d7747
Compare
newhoggy
force-pushed
the
windows-builds
branch
from
51d7747 to
f683c1b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.