Fix build for cabal users that don't have systemd #1775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hasufell
requested review from
dcoutts,
erikd,
intricate,
Jimbo4350,
mrBliss and
newhoggy
as code owners
|
very good point! we should add documentation for this case also in https://github.com/input-output-hk/iohk-monitoring-framework |
hasufell
force-pushed
the
hasufell/PR/cabal-systemd
branch
from
a1ccda4 to
b143dd1
Compare
|
ping |
|
I have also having the same issue on Debian 10, tried the mentioned 2 fixes in the previous thread none of them works. |
|
@feraldruid22 download the file in this PR: https://github.com/input-output-hk/cardano-node/pull/1775/files#diff-5739590c0f8579b6c8fac793aac34e6c run it. Then invoke cabal as such: |
|
I confirm this fixes https://github.com/2nd-Layer/docker-hub-cardano-images/issues/36 and #1200 |
|
Is anyone going to review this? |
|
Works for me in Docker Centos Base...
…--
Sent from mobile
Best regards / S pozdravem,
BSc. Mark Stopka, BBA
Managing Partner @ PERLUR Group
mobile: +420 704 373 561
website: www.perlur.cloud
On Thu, Oct 1, 2020, 19:35 Julian Ospald ***@***.***> wrote:
Is anyone going to review this?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#1775 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEKMP3DGXYDYUG44M6Y4VNDSIS4XFANCNFSM4QM327ZQ>
.
|
intricate
reviewed
Oct 1, 2020
intricate
approved these changes
Oct 1, 2020
There was a problem hiding this comment.
This looks fine to me, but I'd also like a review from @erikd since he suggested this solution in #1666 (review).
erikd
approved these changes
Oct 1, 2020
This is mainly due to a cabal bug and should be removed in the future: haskell/cabal#5444 There are various distros, where installing development files of libsystemd won't be an option: - Alpine (doesn't have systemd at all) - Gentoo (not installable when eudev is installed) - Exherbo (not installable when eudev is installed) Users are expected to run the script and then execute cabal like so: cabal build --project-file=cabal.nosystemd.project all
hasufell
force-pushed
the
hasufell/PR/cabal-systemd
branch
from
b143dd1 to
b490fcf
Compare
|
bors merge |
|
🔒 Permission denied Existing reviewers: click here to make hasufell a reviewer |
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mainly due to a cabal bug and should be removed in
the future: haskell/cabal#5444
There are various distros, where installing development files
of libsystemd won't be an option:
Users are expected to run the script and then execute cabal like so:
cabal build --project-file=cabal.nosystemd.project all
related:
This has also been discussed on slack.
Instructions for this edge case should probably be added to the wiki?