Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test delegation and withdraw using plutus v2 reference script #1353

Merged
merged 2 commits into from
Sep 13, 2022
Merged

test delegation and withdraw using plutus v2 reference script #1353

merged 2 commits into from
Sep 13, 2022

Conversation

saratomaz
Copy link
Collaborator

No description provided.

@saratomaz saratomaz requested a review from mkoura September 2, 2022 10:53
@saratomaz saratomaz marked this pull request as ready for review September 2, 2022 14:46
mkoura
mkoura requested changes Sep 5, 2022
View reviewed changes
Copy link
Collaborator

@mkoura mkoura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's very little difference between test_plutus_delegation.py and test_plutus_v2_delegation.py. Therefore I suggest to parametrize the test test_delegate_deregister in test_plutus_delegation.py.

@saratomaz saratomaz force-pushed the plutus_v2_delegation_with_reference_script branch from df31acd to 99046fd Compare September 7, 2022 11:42
@saratomaz saratomaz requested a review from mkoura September 7, 2022 11:43
@saratomaz saratomaz force-pushed the plutus_v2_delegation_with_reference_script branch 2 times, most recently from 30fee2a to 0205157 Compare September 8, 2022 13:11
@saratomaz saratomaz force-pushed the plutus_v2_delegation_with_reference_script branch from 0205157 to 5beab03 Compare September 8, 2022 20:52
@saratomaz saratomaz requested a review from mkoura September 8, 2022 20:52
saratomaz and others added 2 commits September 9, 2022 16:47
@saratomaz @mkoura
test delegation and withdraw using plutus v2 reference script
c8c6f97
@mkoura
Fix txouts and tx indexes
9de3784 
There was one redundant txout and tx indexes worked just because of that. On current master tx indexes start from 0 (index 0 used to be change when `transaction build` is used)
@mkoura mkoura force-pushed the plutus_v2_delegation_with_reference_script branch from 5beab03 to 9de3784 Compare September 9, 2022 21:13
@mkoura mkoura merged commit e085a5c into IntersectMBO:master Sep 13, 2022
@catch-21 catch-21 mentioned this pull request Feb 26, 2025
Open
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkoura mkoura mkoura approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@saratomaz @mkoura