Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:bgplay stuck issue #298

Merged
merged 1 commit into from
Mar 3, 2023

Conversation

VenomFate-619
Copy link
Contributor

Description

As mentioned in the issue we need to replace RIPE bgplay component with the bgplay code directly. I had done that.
For reference

Motivation and Context

The website used to have a working version of BGPlay.Somehow this is not working anymore. So to resolve this I created this PR

#74

How Has This Been Tested?

I tested it on different ASN.

Screenshots (if appropriate):

localhost_8080_ihr_en-us_networks_AS2497_rov_tb=routes hege_tb=bgpPlay hege_dt=2023-02-28%2014%3A30 af=4 last=3 date=2023-03-02

image

ihr-bgplay.mp4

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Note:-
there can be some scenarios that I haven't covered while testing because I am unaware of them. I need a little favour do check this out before merging.
If one tries to change anything from the setting section of bgplay it will be stuck at the loading due to this below issue
image
image

this might be removed after it is deployed

@romain-fontugne
Copy link
Member

Wonderful! Thanks so much, I'm really glad to see that working again!

@romain-fontugne romain-fontugne merged commit bf3dcec into InternetHealthReport:master Mar 3, 2023
@VenomFate-619 VenomFate-619 deleted the bug/74 branch March 3, 2023 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants