Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add relations for TERMINATED in state diagrams #43

Merged
merged 2 commits into from
Aug 10, 2023

Conversation

juliapampus
Copy link
Contributor

@juliapampus juliapampus commented Feb 17, 2023

I know this makes it less clear, but actually more correct. WDYT?

Closes #42

@juliapampus juliapampus changed the title chore: add relations for TERMINATED to state diagrams chore: add relations for TERMINATED in state diagrams Feb 17, 2023
@sebbader-sap
Copy link
Contributor

Thinking about it, shouldn't both parties be allowed to send a termination at any state? E.g. the Consumer sends a ContractRequestMessage, which is received successfully, but then he realises that he has made a mistake (wrong Contract Offer for instance). In that case the Consumer should also be allowed to terminate the negotiation and "revoke" his initial step.

Copy link
Member

@ssteinbuss ssteinbuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matgnt
Copy link
Collaborator

matgnt commented Mar 30, 2023

Another option for better readability could be to not add the state changes to the picture, but only to the text, like "all states can transition to terminated" (or similar...). I think it is easier to read the picture without all the "terminated" transitions.

@juliapampus juliapampus marked this pull request as draft May 12, 2023 11:50
@juliapampus juliapampus self-assigned this May 12, 2023
@juliapampus juliapampus force-pushed the refactor/update_state_machine_diagrams branch from 07c67f4 to 4511bea Compare August 3, 2023 07:23
@juliapampus juliapampus requested review from ssteinbuss, jimmarino and sebbader-sap and removed request for jimmarino and sebbader-sap August 3, 2023 07:24
@juliapampus
Copy link
Contributor Author

Agreed on 30.03.: At the beginning, both parties can transition to TERMINATED, towards the end, it becomes stricter

@juliapampus
Copy link
Contributor Author

@ssteinbuss This needs your approval.

@juliapampus juliapampus merged commit 2546b78 into main Aug 10, 2023
@juliapampus juliapampus deleted the refactor/update_state_machine_diagrams branch August 10, 2023 07:07
SebastianOpriel pushed a commit to SebastianOpriel/ids-specification that referenced this pull request Aug 11, 2023
…Data-Spaces-Association#43)

* chore: add relations for TERMINATED to state diagrams

* chore: apply feedback
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add transitions to state TERMINATED
4 participants