-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add relations for TERMINATED in state diagrams #43
Conversation
Thinking about it, shouldn't both parties be allowed to send a termination at any state? E.g. the Consumer sends a ContractRequestMessage, which is received successfully, but then he realises that he has made a mistake (wrong Contract Offer for instance). In that case the Consumer should also be allowed to terminate the negotiation and "revoke" his initial step. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Please check back with refactor: remove CONSUMER_ and PROVIDER_ prefixes from CN states #71 and include the new names from refactor: remove CONSUMER_ and PROVIDER_ prefixes from CN states #71 here
- Please include a certain degree of freedom in the initial states
Another option for better readability could be to not add the state changes to the picture, but only to the text, like "all states can transition to terminated" (or similar...). I think it is easier to read the picture without all the "terminated" transitions. |
07c67f4
to
4511bea
Compare
Agreed on 30.03.: At the beginning, both parties can transition to |
@ssteinbuss This needs your approval. |
…Data-Spaces-Association#43) * chore: add relations for TERMINATED to state diagrams * chore: apply feedback
I know this makes it less clear, but actually more correct. WDYT?
Closes #42