Add pagination and filter changes #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimmarino
requested review from
sebbader-sap,
JulianLegler,
ssteinbuss and
matgnt
matgnt
approved these changes
Feb 13, 2024
There was a problem hiding this comment.
I can't see the diff in this file except the whitespace at the end, which is probably not intended.
12 tasks
sebbader-sap
approved these changes
Feb 14, 2024
ssteinbuss
approved these changes
Feb 15, 2024
ssteinbuss
merged commit e5b658a
into
International-Data-Spaces-Association:main
1 check passed
ssteinbuss
added a commit
that referenced
this pull request
Feb 15, 2024
* ci: fix typo for file check workflow (#215) * ci: fix typo * ci: remove duplicated workflow trigger * Update context.json (#216) * replace odrl:offer/odrl:agreement with dspace:offer/dspace:agreement (#221) * extend explanation on dspace-trust child resources (#222) * Replace providerId/consumerId with odrl:assigner / odrl:assignee (#213) * replace providerId/consumerId with odrl:assigner / odrl:assignee * replace providerId/consumerId in contract.negotiation.protocol * fix the ToC in contract.negotiation.binding.https * Update model documents (#229) * Add pagination and filter changes (#228) * Add pagination and filter changes * Change continuation tokens * Adds auth description to common bindings document (#227) * Add description * Remove auth sections * Remove auth sections from catalog * Remove subchapter on Versioning (#225) * remove subchapter on versioning from the https binding * fix table of content * Cleanup `EndpointProperty` inconsistencies and specify `authType` (#218) * Specify auth type property; clarify authorization property and make case consistent; remove incorrect bearer prefix; remove non-normative S3 reference * Add descriptions * Remove S3 reference * Remove S3 reference * Revert releases folder change * Emphazising that the spec does not cover the data transfer (#230) * Highlighting the text by formatting * Adding further explanation --------- Co-authored-by: Julia Pampus <[email protected]> Co-authored-by: Maarten Kollenstart <[email protected]> Co-authored-by: sebbader-sap <[email protected]> Co-authored-by: Jim Marino <[email protected]>
ssteinbuss
added a commit
that referenced
this pull request
Feb 16, 2024
* Update model.md * Splitting to not-normative and normative part * adding description on registry * Fix formatting * Update model.md Adding intro text * Update model/model.md fixing typo Co-authored-by: Jim Marino <[email protected]> * Fix formatting * Adding link to terminology * Update model/model.md Co-authored-by: Julia Pampus <[email protected]> * update branch (#231) * ci: fix typo for file check workflow (#215) * ci: fix typo * ci: remove duplicated workflow trigger * Update context.json (#216) * replace odrl:offer/odrl:agreement with dspace:offer/dspace:agreement (#221) * extend explanation on dspace-trust child resources (#222) * Replace providerId/consumerId with odrl:assigner / odrl:assignee (#213) * replace providerId/consumerId with odrl:assigner / odrl:assignee * replace providerId/consumerId in contract.negotiation.protocol * fix the ToC in contract.negotiation.binding.https * Update model documents (#229) * Add pagination and filter changes (#228) * Add pagination and filter changes * Change continuation tokens * Adds auth description to common bindings document (#227) * Add description * Remove auth sections * Remove auth sections from catalog * Remove subchapter on Versioning (#225) * remove subchapter on versioning from the https binding * fix table of content * Cleanup `EndpointProperty` inconsistencies and specify `authType` (#218) * Specify auth type property; clarify authorization property and make case consistent; remove incorrect bearer prefix; remove non-normative S3 reference * Add descriptions * Remove S3 reference * Remove S3 reference * Revert releases folder change * Emphazising that the spec does not cover the data transfer (#230) * Highlighting the text by formatting * Adding further explanation --------- Co-authored-by: Julia Pampus <[email protected]> Co-authored-by: Maarten Kollenstart <[email protected]> Co-authored-by: sebbader-sap <[email protected]> Co-authored-by: Jim Marino <[email protected]> * Merging definitions of dataspace registry * Clarifing that the Rulebook content is non-normative and an example * Update model/model.md Co-authored-by: Jim Marino <[email protected]> --------- Co-authored-by: Jim Marino <[email protected]> Co-authored-by: Julia Pampus <[email protected]> Co-authored-by: Maarten Kollenstart <[email protected]> Co-authored-by: sebbader-sap <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the following:
Note that pagination "normative" cannot be done in the abstract protocol specification as some transports may not support (or want to support) pagination. We also should not make pagination "mandatory" since an implementation may choose not to offer it (which, for most catalogs, even large ones, is likely not necessary given support for compression technologies) or choose to perform it on every type of request. Making it "normative" means when pagination is performed, it is serialized in a certain format.
Note that I did not change the Technical Considerations section. It offers important information about the protocol design (not implementation-specific information) that is valuable to retain.
Closes #194