Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

104 introduce best practices document #146

Merged
merged 5 commits into from
Oct 26, 2023
Merged

104 introduce best practices document #146

merged 5 commits into from
Oct 26, 2023

Conversation

ssteinbuss
Copy link
Member

As discussed during the last meetings the PR contains an initial structure to create a best practices document.

  • The README.md of the specification contains a teaser for the Best Practices
  • A generic introduction in the README.md of the best practices
  • The following sections:
    • Related documents
    • Examples
    • How to extend the dataspace protocol
    • How to create a new binding
    • Known implementations
    • Security considerations
  • Lined the best practices to the GitBook rendering

@ssteinbuss ssteinbuss linked an issue Aug 24, 2023 that may be closed by this pull request
Introduce best practices document #104
Closed
@ssteinbuss ssteinbuss self-assigned this Aug 24, 2023
@juliapampus juliapampus mentioned this pull request Aug 31, 2023
Draft
juliapampus
juliapampus approved these changes Sep 14, 2023
View reviewed changes
Copy link
Contributor

@juliapampus juliapampus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest looks good to me

best.practices/README.md Outdated Show resolved Hide resolved
best.practices/README.md Outdated Show resolved Hide resolved
best.practices/README.md Outdated Show resolved Hide resolved
best.practices/README.md Outdated Show resolved Hide resolved
best.practices/README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@sebbader-sap
Copy link
Contributor

@ssteinbuss please check the comments and either integrate them or merge directly.

@ssteinbuss ssteinbuss merged commit 554575b into main Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliapampus juliapampus juliapampus approved these changes

Assignees

@ssteinbuss ssteinbuss

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Introduce best practices document
3 participants
@ssteinbuss @sebbader-sap @juliapampus