Update dcat.distribution.example.json #1

hosseinzadeha · 2022-12-07T10:50:29Z

Minor updates:

Namespaces are defined in the @context block.
ODRL policy is identified with "uid" attribute.
hasPolicy attribute belongs to ODRL namespace.
either "ids:equals" or "odrl:eq" operators shall be used.
"idsc:SECURITY_LEVEL" and "idsc:TRUST_SECURITY_PROFILE" values are compatible with the latest version of IDS info model.

@context

Minor updates: - Namespaces are defined in the @context block. - ODRL policy is identified with "uid" attribute. - hasPolicy attribute belongs to ODRL namespace. - either "ids:equals" or "odrl:eq" operators shall be used. - "idsc:SECURITY_LEVEL" and "idsc:TRUST_SECURITY_PROFILE" values are compatible with the latest version of IDS info model.

juliapampus

Thanks for this contribution! I guess this covers some discussion points we had in the last weeks :D

Edit: If we agreed to change something, we should do it in all affected files with this PR.

juliapampus · 2022-12-13T14:25:28Z

catalog/example/dcat.distribution.example.json

@@ -1,5 +1,12 @@
 {
-    "@context":  "https://w3id.org/idsa/v5/context.json",
+    "@context": [


According to @sebbader, this can be replaced by defining a general context.json and reference every used namespace in there.

Yes, that's correct and valid for @context.

@hosseinzadeha please keep the original context line.

juliapampus · 2022-12-13T14:28:14Z

catalog/example/dcat.distribution.example.json

@@ -14,15 +21,15 @@
        "high value data",
        "example"
    ],
-    "dcat:hasPolicy": {
+    "odrl:hasPolicy": {


We had odrl but changed it to dcat. Anyone remembers why? @jimmarino @sebbader

I'm not sure. It should be in the ODRL namespace.

Correct, I found it in the DCAT overview picture but didn't realise that it was originally from ODRL.

juliapampus · 2022-12-13T14:31:21Z

catalog/example/dcat.distribution.example.json

-                "odrl:leftOperand": "ids:SECURITY_PROFILE",
-                "odrl:operand": "odrl:equals",
-                "odrl:rightOperand": "ids:TRUST_PLUS"
+                "odrl:leftOperand": "idsc:SECURITY_LEVEL",


We also had a discussion on ids and idsc. We agreed on not having any need for a separation of both namespaces. Is there a need? @hosseinzadeha

In the current version of IDS info model, this left operand is defined as idsc:SECURITY_LEVEL. Of course, we don't mind if the namespace is changed, but if we want to rename the "security level" to "security profile", we would need to know and update our policy editor (PAP) accordingly.

if we want to rename the "security level" to "security profile"

I want to change as little as possible, so better not do it. I wrote the examples 'by hand' - errors like this one included. Thanks for the correction! The 'normative' part is in the schemas, which are not finished yet.

I think we should define rules for how we approach namespaces. I would be OK with the following:

All mandatory elements identified in the "core" Catalog, Contract Negotiation, and Transfer Process specs are defined in a single "IDS" namespace.

Certification elements are not defined in the core IDS specifications and are put into a separate "IDSC" namespace.

Regarding #2, those elements do not need to be supported for an implementation to be declared "specification compliant." This is essential because we must allow compliant implementations without requiring a certification process.

In my view, "SECURITY_LEVEL" is a certification element and therefore not required for "specification compliance." This distinction between "compliance" and "certification" is also important because all mandatory normative statements in the specification ("compliance") must be testable in an automated (and objective) fashion. Certification does not meet those criteria.

@jimmarino let's discuss this in #2.

juliapampus · 2022-12-13T14:33:36Z

catalog/example/dcat.distribution.example.json

        "@type": "odrl:Offer",
-        "@id": "https://provider.com/edc/offer/1",
+        "uid": "https://provider.com/edc/offer/1",


I remember we changed this on purpose? @jimmarino

Yes, we changed this to match with JSON-LD. This will be one of the things we need to profile ODRL.

A bit more tricky, unfortunately. In the JSON-LD, "@id" and only "@id" is correct, "odrl:uid" shall not appear at all. In Turtle and other RDF formats, "odrl:uid" must appear (which is a mistake in the ODRL vocabulary). Long story short, the ODRL-way is syntactically correct but "not the way it should be". I am asking you to trust me here, explaining it in all details takes a bit more time than we all have ;-)

@hosseinzadeha please change this back to "@id".

sebbader-sap

Hi @hosseinzadeha, thanks for the remarks! I am completely fine with the other updates, please just undo the two positions where I have commented.

sebbader-sap · 2022-12-19T15:39:39Z

catalog/example/dcat.distribution.example.json

        "@type": "odrl:Offer",
-        "@id": "https://provider.com/edc/offer/1",
+        "uid": "https://provider.com/edc/offer/1",


@hosseinzadeha please change this back to "@id".

sebbader-sap · 2022-12-19T15:40:08Z

catalog/example/dcat.distribution.example.json

@@ -1,5 +1,12 @@
 {
-    "@context":  "https://w3id.org/idsa/v5/context.json",
+    "@context": [


@hosseinzadeha please keep the original context line.

uid and context changes reverted

add references for reused classes & datatypes

@id

* adding DCAT into JSON schema * catalog schema DCAT fix * fix catalog schema - DCAT * fix catalog schema type error - DCAT * DCAT catalog-shape added for Catalog class * fix typo in DCAT of catalog schema * fix type of dct:modified in DCAT of catalog schema * DCAT dcat:CatalogRecord class added to catalog shape * fix DCAT referecen in Resource catalog * DCAT wrong property of Resource removed * Fix DCAT catalog property of Resource * ResourceShape added to catalog-shape.ttl * RelationshipShape added to catalog-shape.ttl * DCAT fix issue in skos:Concept * DCAT ConceptShape ConceptSchemeShape and AgentShape added * DCAT fix of Dataset property * DCAT DatasetShape added * DCAT DataServiceShape added * DCAT Distribution catalog issue in type * DCAT typo in property * DCAT DataServiceShape added * add references for reused classes & datatypes * clean up on schema * properties changed * refactoring * refactoring * change dct:issued from string to dateTime * fix dct:language from xsd:string to referencing a resource * correcting hasPolicy declarations * reviewing the catalog json schema * refactor catalog json schema * add odrl policy json schema * fix syntax bugs in catalog json schema and adding foaf to the context.json * fix bugs in catalog and contract json schemas * fix examples to match to the catalog and contract json schemas * replace relative reference to the contract-schema.json with an absolute url * fix findings from mkollenstart's review * testing negotiation-subtask-1.1 branch * removing the test change * unwnated characters * Task #1: fix schemas and examples in "negotiation" * correct references to GitHub raw files * making 'required' field compatible to json 2019-09 * changes suggested by Sebastian * changes to processId, correcting ref, removing Sec * chnages since last review * left over change * missing s in dspace * removing RightOperand property * chnage in Permission, Json validated * catalog subtask changes * reverting dspace:filter type to object * re-introducing updates to the json schemas * fix filter in contract-request-message-schema * fixing schema in "Transfer" * Trying Shapes validation with Json-LD * debugging catalog shapes * fixing shapes in Catalog * Negotaitaion Shapes validation * Remove the ContractAgreement shape * add the AgreementShape * Negotiation shapes correction * conflict merge * schema and shapes re-validating after merge * change assigner and assignee to string * introduve verifiable credential structure to agreement msg * adjust agreement msg example to vc pattern * comment error * Catalog shapes changes * Shapes and schema validation for Transfer * Introduce sh:IRI pattern for agreementId * correction for dspace:reason and others * dataset schema and puml * Update catalog-error-schema.json - remove "dspace:code" and "dspace:reason" as mandatory * Update dataset-schema.json - remove "dct:title" and "dct:description" as mandatory * agreement verification change * Transfer Messages - shapes and schema validation * removing "@id" from transfer messages * correction for catalog schema * error handling * pull request #11 changes * pull request changes * new chnages to editorial-rework * merge editorial-rework to shapes-and-schemas * fix last findings --------- Co-authored-by: Thomas Ryborz <[email protected]> Co-authored-by: tr-sap <[email protected]> Co-authored-by: SimantVerma-Bcone <[email protected]> Co-authored-by: simantvermasap <[email protected]>

@id

* adjust wording in the readme and summary * adjust wording in the transfer process chapter * fix the transfer protocol resources * keep shacl messages for dspace:code consistent also in the negotiation msgs * remove the unneeded message shape * adjust the wording in the transfer protocol binding * revert data plane / control plane deletion * resort terms and terminology statements * resolve remaining conflicts * aligning chapter title pattern * fixing inconsistencies in the dcat:Catalog descriptions * adjust wording in the readme and summary * adjust wording in the transfer process chapter * fix the transfer protocol resources * keep shacl messages for dspace:code consistent also in the negotiation msgs * remove the unneeded message shape * adjust the wording in the transfer protocol binding * revert data plane / control plane deletion * resort terms and terminology statements * resolve remaining conflicts * aligning chapter title pattern * fixing inconsistencies in the dcat:Catalog descriptions * chore: add linkage for provider term * chore: add linkage for consumer term * chore: remove reference to OpenAPI spec * fix missing attributes from catalog, dataset, distribution etc. * minor fixes in the negotiation section * chore: update terminology * chore: cleanup protocol document (CN) * refactor: move .json files to example folders * chore: align transfer terminology * chore: clean up negotiation http binding * docs: update README * chore: restructure catalog procotol * chore: update common .md files * chore(CN-binding): remove connector, add callback from/to URL * chore(CN): update response type description * chore: clean up catalog http binding * chore: fix JSON snippets * chore: update formatting of model.md * chore: revert removing credential issuer * chore(CN): resolve leftover copy&paste mistakes * chore: restructure transfer protocol document * chore: move protocol figures to sub-folder * chore: clean up transfer http binding * chore: align documents * chore(catalog): change section hierarchy * chore: add ToCs to protocol & binding documents * chore: update broken/missing links in list files * chore(CN-termination): align type of `code` with spec documents * chore(CN): clean up diagram files * chore: update terminology.md * switch links for the catalog and dataset resources * correct dcat:keyword in the catalog example * replace UUID with "identifier" in model.md * add example as the schema for the catalog example uuid * fix the dataset-request-message diagram * Editorial rework merge (#2) (#209) * adding DCAT into JSON schema * catalog schema DCAT fix * fix catalog schema - DCAT * fix catalog schema type error - DCAT * DCAT catalog-shape added for Catalog class * fix typo in DCAT of catalog schema * fix type of dct:modified in DCAT of catalog schema * DCAT dcat:CatalogRecord class added to catalog shape * fix DCAT referecen in Resource catalog * DCAT wrong property of Resource removed * Fix DCAT catalog property of Resource * ResourceShape added to catalog-shape.ttl * RelationshipShape added to catalog-shape.ttl * DCAT fix issue in skos:Concept * DCAT ConceptShape ConceptSchemeShape and AgentShape added * DCAT fix of Dataset property * DCAT DatasetShape added * DCAT DataServiceShape added * DCAT Distribution catalog issue in type * DCAT typo in property * DCAT DataServiceShape added * add references for reused classes & datatypes * clean up on schema * properties changed * refactoring * refactoring * change dct:issued from string to dateTime * fix dct:language from xsd:string to referencing a resource * correcting hasPolicy declarations * reviewing the catalog json schema * refactor catalog json schema * add odrl policy json schema * fix syntax bugs in catalog json schema and adding foaf to the context.json * fix bugs in catalog and contract json schemas * fix examples to match to the catalog and contract json schemas * replace relative reference to the contract-schema.json with an absolute url * fix findings from mkollenstart's review * testing negotiation-subtask-1.1 branch * removing the test change * unwnated characters * Task #1: fix schemas and examples in "negotiation" * correct references to GitHub raw files * making 'required' field compatible to json 2019-09 * changes suggested by Sebastian * changes to processId, correcting ref, removing Sec * chnages since last review * left over change * missing s in dspace * removing RightOperand property * chnage in Permission, Json validated * catalog subtask changes * reverting dspace:filter type to object * re-introducing updates to the json schemas * fix filter in contract-request-message-schema * fixing schema in "Transfer" * Trying Shapes validation with Json-LD * debugging catalog shapes * fixing shapes in Catalog * Negotiation Shapes validation * Remove the ContractAgreement shape * add the AgreementShape * Negotiation shapes correction * conflict merge * schema and shapes re-validating after merge * change assigner and assignee to string * introduve verifiable credential structure to agreement msg * adjust agreement msg example to vc pattern * comment error * Catalog shapes changes * Shapes and schema validation for Transfer * Introduce sh:IRI pattern for agreementId * correction for dspace:reason and others * dataset schema and puml * Update catalog-error-schema.json - remove "dspace:code" and "dspace:reason" as mandatory * Update dataset-schema.json - remove "dct:title" and "dct:description" as mandatory * agreement verification change * Transfer Messages - shapes and schema validation * removing "@id" from transfer messages * correction for catalog schema * error handling * pull request #11 changes * pull request changes * new chnages to editorial-rework * merge editorial-rework to shapes-and-schemas * fix last findings --------- Co-authored-by: Thomas Ryborz <[email protected]> Co-authored-by: tr-sap <[email protected]> Co-authored-by: SimantVerma-Bcone <[email protected]> Co-authored-by: simantvermasap <[email protected]> * fix typo in contract negotiation binding * revert changes to the release folder * add note on callback paths * chore: update broken ToCs * chore: markdown inspection * fix: revert changes to release folder * chore: apply minor improvements --------- Co-authored-by: Julia Pampus <[email protected]> Co-authored-by: Thomas Ryborz <[email protected]> Co-authored-by: tr-sap <[email protected]> Co-authored-by: SimantVerma-Bcone <[email protected]> Co-authored-by: simantvermasap <[email protected]>

juliapampus reviewed Dec 13, 2022

View reviewed changes

sebbader-sap self-requested a review December 19, 2022 15:38

sebbader-sap requested changes Dec 19, 2022

View reviewed changes

Update dcat.distribution.example.json

b650db9

uid and context changes reverted

sebbader-sap mentioned this pull request Dec 20, 2022

IDS Namespaces #2

Closed

sebbader-sap approved these changes Dec 20, 2022

View reviewed changes

sebbader-sap merged commit 60d157b into International-Data-Spaces-Association:main Dec 20, 2022

sebbader-sap pushed a commit that referenced this pull request Apr 17, 2023

Merge pull request #1 from tr-sap/review_sebastian

bbc579b

add references for reused classes & datatypes

simantvermasap referenced this pull request in simantvermasap/ids-specification Sep 7, 2023

Task #1: fix schemas and examples in "negotiation"

9e6ec39

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update dcat.distribution.example.json #1

Update dcat.distribution.example.json #1

hosseinzadeha commented Dec 7, 2022

juliapampus left a comment •

edited

Loading

juliapampus Dec 13, 2022

jimmarino Dec 13, 2022

sebbader-sap Dec 19, 2022

juliapampus Dec 13, 2022

jimmarino Dec 13, 2022

sebbader-sap Dec 19, 2022

juliapampus Dec 13, 2022

hosseinzadeha Dec 13, 2022

sebbader-sap Dec 19, 2022

jimmarino Dec 20, 2022 •

edited

Loading

sebbader-sap Dec 20, 2022

juliapampus Dec 13, 2022

jimmarino Dec 13, 2022

sebbader-sap Dec 19, 2022 •

edited

Loading

sebbader-sap Dec 19, 2022

sebbader-sap left a comment

sebbader-sap Dec 19, 2022

sebbader-sap Dec 19, 2022

Update dcat.distribution.example.json #1

Update dcat.distribution.example.json #1

Conversation

hosseinzadeha commented Dec 7, 2022

juliapampus left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jimmarino Dec 20, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sebbader-sap Dec 19, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sebbader-sap left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

juliapampus left a comment •

edited

Loading

jimmarino Dec 20, 2022 •

edited

Loading

sebbader-sap Dec 19, 2022 •

edited

Loading