Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
15 review process layer and broker #76
15 review process layer and broker #76
Changes from 11 commits
d076361
5d2b55d
d18e4a1
c39dcee
5f5f8f8
3752685
1505537
fe3da24
9b2de7f
a8ad80d
cc16184
3f880f0
db05d0d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"This certificate enables them to establish secure and trusted connections to other IDS participants" is maybe misleading. Because the next sentence states that this certificate is not used to create secured SSL connections. So maybe a better description of this certificate would be "This certificate is used in communication with others to proof the identity of this organization to others and is therefore called the IDS identity certificate."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"This certificate is deployed locally to enable Transport Layer Security (TLS) and identification of the respective IDS participant...". That sounds like there is ALWAYS ONE certificate that does both, TLS AND identification of the IDS participant. But in the next sentence it is stated that there can be an SSL certificate and an IDS identity certificate.
Maybe this should be split up: "To enable secure communication an SSL certificate must be installed..." and then "To make the connector identify itself to others an IDS identity certificate must be installed..."