Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 4_2_5_Processes.md #144

Merged
merged 12 commits into from
Apr 14, 2022
Merged

Update 4_2_5_Processes.md #144

merged 12 commits into from
Apr 14, 2022

Conversation

Sonia-IDSA
Copy link
Contributor

No description provided.

@mokamhuber
Copy link
Contributor

@Sonia-IDSA thanks a lot for preparing this chapter! I have reviewed it and provided some feedback and proposal for changes :)

@mokamhuber mokamhuber linked an issue Feb 28, 2022 that may be closed by this pull request
Sonia-IDSA and others added 6 commits March 1, 2022 15:54
…el/4_2_Certification_Perspective/4_2_5_Processes.md

Co-authored-by: Monika Huber <[email protected]>
…el/4_2_Certification_Perspective/4_2_5_Processes.md

Co-authored-by: Monika Huber <[email protected]>
…el/4_2_Certification_Perspective/4_2_5_Processes.md

Co-authored-by: Monika Huber <[email protected]>
…el/4_2_Certification_Perspective/4_2_5_Processes.md

Co-authored-by: Monika Huber <[email protected]>
…el/4_2_Certification_Perspective/4_2_5_Processes.md

Co-authored-by: Monika Huber <[email protected]>
…el/4_2_Certification_Perspective/4_2_5_Processes.md

Co-authored-by: Monika Huber <[email protected]>
@mokamhuber mokamhuber requested a review from pedro-pinto March 9, 2022 11:18
@mokamhuber
Copy link
Contributor

hey @Sonia-IDSA and @pedro-pinto
what is the status with this section and its review?
It would be great if we could get the review finished and the pull request merged during the next days...

@mokamhuber
Copy link
Contributor

Hey @Sonia-IDSA
could you maybe finish integrating the feedback so that we can get this chapter finalized? Thanks!

@mokamhuber mokamhuber mentioned this pull request Apr 13, 2022
@mokamhuber
Copy link
Contributor

Hey @nadjamenz @ssteinbuss and @andreas-teuscher
Sonia and I have finished the revision and review of this chapter but for merging the Pull Request we require a second approval. Could one of you maybe take a short look to the chapter and approve it? Thanks!

@nadjamenz
Copy link
Contributor

@mohuber @Sonia-IDSA The changes look good, but there is still an open todo ([TODO: Add chapter on approval of evaluation facilities]). Will this be worked on after finalizing the current Pull Request?

@mokamhuber
Copy link
Contributor

@nadjamenz thanks for the review!
The first process (Approval of evaluation facilities) has already been covered in another pull request: #141.
Github should be able to automatically merge these together leaving no open points in the chapter.

Copy link
Contributor

@nadjamenz nadjamenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes approved, with the one open todo in this Merge Request being covered in #141.

@mokamhuber mokamhuber merged commit 9cd8b88 into main Apr 14, 2022
@mokamhuber mokamhuber deleted the 4_2_5_2_Certification-Process branch April 14, 2022 07:17
@andreas-teuscher
Copy link

andreas-teuscher commented Apr 14, 2022

This changes are also fine for me.

@mokamhuber
Copy link
Contributor

Thanks to both of you @nadjamenz and @andreas-teuscher for the second review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sec. 4.2.5. Certification Process revise
4 participants