Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update 4_1_1_Security_Aspects_adressed_by_the_different_layers.md #132

Merged
merged 4 commits into from
Mar 25, 2022
Merged

Update 4_1_1_Security_Aspects_adressed_by_the_different_layers.md #132

merged 4 commits into from
Mar 25, 2022

Conversation

gbrost
Copy link
Contributor

@gbrost gbrost commented Feb 16, 2022

No description provided.

@mokamhuber mokamhuber marked this pull request as draft February 21, 2022 08:09
@mokamhuber
Copy link
Contributor

@gbrost I have just revised the chapter. Maybe you can take another look and check if everything makes sense

gbrost
gbrost commented Feb 21, 2022
View reviewed changes
Copy link
Contributor Author

@gbrost gbrost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me....

@mokamhuber mokamhuber marked this pull request as ready for review February 21, 2022 16:23
@mokamhuber mokamhuber linked an issue Feb 21, 2022 that may be closed by this pull request
4.1.1 Security Aspects Addressed by the Different Layers of the IDS-RAM #80
Closed
HeinrichPet
HeinrichPet reviewed Mar 8, 2022
View reviewed changes
Copy link
Contributor

@HeinrichPet HeinrichPet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In section 3.3 and 3.5 we refer to other sections by writing "section X.X" and linking only the number. In this part you write "Chapter X.X" and also link the word Chapter.

@mokamhuber
Copy link
Contributor

In section 3.3 and 3.5 we refer to other sections by writing "section X.X" and linking only the number. In this part you write "Chapter X.X" and also link the word Chapter.

I have changed it from Chapter to Section for consistent wording. Since I have used the link for the word "Section" AND Number in multiple files, I have not yet removed the word from the link to keep it consistent at least within chapter 4.1 and 4.2. If we define a common way for this links for the entire RAM, I would later adjust it if necessary.

@HeinrichPet HeinrichPet merged commit 4d579fd into main Mar 25, 2022
@HeinrichPet HeinrichPet deleted the security-aspects branch March 25, 2022 11:43
juliapampus pushed a commit that referenced this pull request Apr 1, 2022
@gbrost @mokamhuber @juliapampus
Update 4_1_1_Security_Aspects_adressed_by_the_different_layers.md (#132)
ffc28e5 
* Update 4_1_1_Security_Aspects_adressed_by_the_different_layers.md

* Update 4_1_1_Security_Aspects_adressed_by_the_different_layers.md

* revised security aspects

* integrated feedback

Co-authored-by: Huber, Monika <[email protected]>
Co-authored-by: Monika Huber <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmberthold tmberthold tmberthold left review comments

@mokamhuber mokamhuber mokamhuber approved these changes

@HeinrichPet HeinrichPet HeinrichPet approved these changes

@jlangkau jlangkau Awaiting requested review from jlangkau

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4.1.1 Security Aspects Addressed by the Different Layers of the IDS-RAM
4 participants
@gbrost @mokamhuber @HeinrichPet @tmberthold