Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove session_len and deprecated short names of the chat templates #2105

Merged
merged 3 commits into from
Jul 23, 2024

Conversation

lvhan028
Copy link
Collaborator

Motivation

Since the triton inference server backend "turbomind_backend" was removed in #1986, the session_len accessed by the removed Chatbot can be deleted too.

Copy link
Collaborator

@AllentDan AllentDan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

session_len is used in many places.
lmdeploy/turbomind/chat.py:#L92
lmdeploy/pytorch/chat.py:#L108

@lvhan028
Copy link
Collaborator Author

session_len is used in many places. lmdeploy/turbomind/chat.py:#L92 lmdeploy/pytorch/chat.py:#L108

Fixed. Use _get_and_verify_max_len to get the session_len

Copy link
Collaborator

@AllentDan AllentDan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lvhan028 lvhan028 merged commit efa1006 into InternLM:main Jul 23, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants