Keyboard #659

SirEndii · 2024-09-23T15:36:09Z

Please check if the PR fulfills these requirements

The commit message are well described
Docs have been added / updated
All changes have fully been tested

What kind of change does this PR introduce? (Bug fix, feature, ...)
Feature
What is the new behavior (if this is a feature change)?
Added the keyboard item. An item which can be linked to a computer. A user can now right click the item to unlock their mouse, they can now freely type while the typed characters are send to the linked computer. Will also be a module for the smart glasses.
Does this PR introduce a breaking change? (What changes might users need to make in their scripts due to this PR?)
No
Other information:

…and simple screen to unlock the mouse

…oard Also fixed colored messages for the memory card and cleaned up the translation keys

SirEndii · 2024-09-24T12:34:14Z

So the keyboard works now
I can bound it to a computer, right click it in the air and start typing. Every key stroke, key presses and releases are synced to the terminal

I now want to remove JEI from the keyboard screen and place a little info text at the top

The last thing I need to do is to implement this as a smart glasses module

…dule keybind. I will see what I will do with the hotkey module or if I will create a new Keybind I've created two new nbt tags to bind the module to the glasses to sync that to the container, I am not sure if there is maybe a better way, but it works

…it was bound to different glasses before

SirEndii · 2024-09-30T10:21:52Z

I think everything is done now. Mouse and keyboard events are working, I got the little info text rendered, JEI does not render anymore and everything works fine as a glasses module

zyxkad

Overall looks good, just have some detail need to deal with

src/main/java/de/srendi/advancedperipherals/client/screens/KeyboardScreen.java

SirEndii · 2024-10-24T15:49:38Z

Sorry to annoy you @SquidDev, just asking you because of #650 (comment)

I used a piece of the TerminalWidget implementation for our keyboard screen. Just asking if this is okay
See
https://github.com/IntelligenceModding/AdvancedPeripherals/pull/659/files#diff-6374267185184dd9bdd6868cb47752c688a105088d0063d0c5bf7992b4e10ec9R19

And maybe you can answer the two comments related to that from zyxkad

SquidDev · 2024-10-24T15:59:32Z

It might be easier to copy what NoTermComputerScreen does, and just create a Terminal but never render it. Plethora's keyboard UI actually just subclasses NoTermComputerScreen directly.

SirEndii · 2024-10-24T16:05:31Z

It might be easier to copy what NoTermComputerScreen does, and just create a Terminal but never render it. Plethora's keyboard UI actually just subclasses NoTermComputerScreen directly.

Thank you, I didn't see that
That would be simpler

github-actions · 2025-01-16T02:39:37Z

Build Preview

You can find files attached to the below linked Workflow Run URL (Logs).

Name	Link
Commit	`1c9a485`
Logs	https://github.com/IntelligenceModding/AdvancedPeripherals/actions/runs/12801308318
Jar Files	AdvancedPeripherals PR 659
Expires At	2025-04-16T03:07:38Z

zyxkad · 2025-01-17T21:32:45Z

build.gradle

@@ -324,11 +324,12 @@ dependencies {
    compileOnly fg.deobf("com.ldtteam:domum_ornamentum:${domumornamentum_version}:universal")
    compileOnly fg.deobf("com.ldtteam:blockui:${blockui_version}")
    // IMPORTANT. This should be removed/commented when running `runData`
-    runtimeOnly fg.deobf("com.ldtteam:minecolonies:${minecolonies_version}")
+    /*runtimeOnly fg.deobf("com.ldtteam:minecolonies:${minecolonies_version}")


I pretend I didn't see those

(although I think you should merge from dev/0.8)

src/main/java/de/srendi/advancedperipherals/client/ClientRegistry.java

zyxkad · 2025-01-17T21:37:31Z

src/main/java/de/srendi/advancedperipherals/client/screens/KeyboardScreen.java

+ * <p>
+ * We just create a terminal which is used to forward all the key presses and mouse clicks but we don't render it.
+ */
+public class KeyboardScreen extends BaseScreen<KeyboardContainer> {


If you do not extend from AbstractContainerScreen, but inherit Screen or GuiComponent, then jade should not render on it

zyxkad · 2025-01-17T21:38:33Z

src/main/java/de/srendi/advancedperipherals/common/container/KeyboardContainer.java

+import org.jetbrains.annotations.NotNull;
+import org.jetbrains.annotations.Nullable;
+
+public class KeyboardContainer extends BaseContainer implements ComputerMenu {


And so we don't need KeyboardContainer anymore

zyxkad · 2025-01-17T21:42:17Z

src/main/java/de/srendi/advancedperipherals/common/items/MemoryCardItem.java

-        if (data.contains("ownerId") && data.contains("owner")) {
-            tooltip.add(EnumColor.buildTextComponent(Component.translatable("item.advancedperipherals.tooltip.memory_card.bound", data.getString("owner"))));
+        if (data.contains("ownerId")) {
+            tooltip.add(EnumColor.buildTextComponent(Component.translatable("item.advancedperipherals.tooltip.binding.boundto", data.getString("ownerId"))));


alr we are not showing ownerId here, we still want show the owner's name, so we need an extra step to turn the id into GameProfile, then get the player's cached name

ah yeah
I can use the new cache thing there I made

Co-authored-by: Kevin Z <[email protected]> Signed-off-by: Srendi <[email protected]>

# Conflicts: # build.gradle # src/generated/resources/.cache/67cce32b1c3cbbcb1f646605f4914e3f196986c2 # src/generated/resources/.cache/c622617f6fabf890a00b9275cd5f643584a8a2c8 # src/generated/resources/assets/advancedperipherals/lang/en_us.json # src/main/java/de/srendi/advancedperipherals/common/data/EnUsLanguageProvider.java # src/main/java/de/srendi/advancedperipherals/common/setup/APItems.java

[IntelligenceModding/Advanced-Peripherals-Features#59] Keyboard item …

8bc766d

…and simple screen to unlock the mouse

SirEndii self-assigned this Sep 23, 2024

SirEndii added enhancement New feature or request 1.19x labels Sep 23, 2024

Remove custom indentation

6695fda

SirEndii added this to the 0.8r milestone Sep 23, 2024

SirEndii added 3 commits September 23, 2024 21:21

Binding/Unbinding for the keyboard

027787b

Use translatable components and add name and description for the keyb…

19f4de9

…oard Also fixed colored messages for the memory card and cleaned up the translation keys

Removed owner tag from the memory card

c507f0a

SirEndii changed the title ~~[IntelligenceModding/Advanced-Peripherals-Features#59] Keyboard item and simple screen to unlock the mouse~~ Keyboard Sep 23, 2024

Key press/Char typed sync to the computer logic

ab6a8cd

SirEndii added 5 commits September 25, 2024 22:10

Mouse events for the keyboard module

b94b8be

Fixed an issue where the keyboard does not bound to the glasses when …

9ba1214

…it was bound to different glasses before

Render a little info text when the player is using the keyboard

e8f70d7

Preven JEI/REI/EMI from rendering in the keyboard screen

1b147a3

SirEndii marked this pull request as ready for review September 30, 2024 10:21

SirEndii requested a review from zyxkad September 30, 2024 10:22

zyxkad reviewed Oct 21, 2024

View reviewed changes

Merge branch 'dev/0.8' into feat/keyboard

48ce6e5

SirEndii added 2 commits January 16, 2025 03:43

checkstyle

b689497

Simplify KeyboardScreen

36193be

SirEndii requested a review from zyxkad January 16, 2025 03:07

zyxkad requested changes Jan 17, 2025

View reviewed changes

SirEndii and others added 3 commits January 17, 2025 22:48

Sort ClientRegistry.java

5e439b9

Co-authored-by: Kevin Z <[email protected]> Signed-off-by: Srendi <[email protected]>

Add language entries

f5efd86

SirEndii mentioned this pull request Jan 18, 2025

Documentation for 0.8 IntelligenceModding/Advanced-Peripherals-Documentation#96

Open

12 tasks

scmcgowen mentioned this pull request Jan 18, 2025

Update documentation for 0.8 IntelligenceModding/Advanced-Peripherals-Documentation#97

Draft

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Keyboard #659

Keyboard #659

SirEndii commented Sep 23, 2024 •

edited

Loading

SirEndii commented Sep 24, 2024

SirEndii commented Sep 30, 2024

zyxkad left a comment

SirEndii commented Oct 24, 2024

SquidDev commented Oct 24, 2024

SirEndii commented Oct 24, 2024

github-actions bot commented Jan 16, 2025 •

edited

Loading

zyxkad Jan 17, 2025

zyxkad Jan 17, 2025

zyxkad Jan 17, 2025

zyxkad Jan 17, 2025

SirEndii Jan 17, 2025

Keyboard #659

Are you sure you want to change the base?

Keyboard #659

Conversation

SirEndii commented Sep 23, 2024 • edited Loading

SirEndii commented Sep 24, 2024

SirEndii commented Sep 30, 2024

zyxkad left a comment

Choose a reason for hiding this comment

SirEndii commented Oct 24, 2024

SquidDev commented Oct 24, 2024

SirEndii commented Oct 24, 2024

github-actions bot commented Jan 16, 2025 • edited Loading

Build Preview

zyxkad Jan 17, 2025

Choose a reason for hiding this comment

zyxkad Jan 17, 2025

Choose a reason for hiding this comment

zyxkad Jan 17, 2025

Choose a reason for hiding this comment

zyxkad Jan 17, 2025

Choose a reason for hiding this comment

SirEndii Jan 17, 2025

Choose a reason for hiding this comment

SirEndii commented Sep 23, 2024 •

edited

Loading

github-actions bot commented Jan 16, 2025 •

edited

Loading