Adjust web side for new tooling changes (Key -> Keys and OrderOnPage) #674
Conversation
Joshua-Lester3
had a problem deploying
to
BuildAndUploadImage
GitHub Actions
Failure
Joshua-Lester3
had a problem deploying
to
BuildAndUploadImage
GitHub Actions
Failure
Joshua-Lester3
had a problem deploying
to
BuildAndUploadImage
GitHub Actions
Failure
Joshua-Lester3
had a problem deploying
to
BuildAndUploadImage
GitHub Actions
Failure
Joshua-Lester3
temporarily deployed
to
BuildAndUploadImage
GitHub Actions
Inactive
Joshua-Lester3
force-pushed
the
BMichaelis/UpdateSitemaps
branch
from
7b2c3ec to
eefdf2d
Compare
Joshua-Lester3
had a problem deploying
to
BuildAndUploadImage
GitHub Actions
Failure
Joshua-Lester3
temporarily deployed
to
BuildAndUploadImage
GitHub Actions
Inactive
BenjaminMichaelis
force-pushed
the
main
branch
from
70452a1 to
23ff1d6
Compare
This reverts commit 710418c.
Joshua-Lester3
force-pushed
the
BMichaelis/UpdateSitemaps
branch
from
eefdf2d to
3a9a1ca
Compare
Joshua-Lester3
temporarily deployed
to
BuildAndUploadImage
GitHub Actions
Inactive
Joshua-Lester3
temporarily deployed
to
BuildAndUploadImage
GitHub Actions
Inactive
| v-on:toggle="!$event.target.open ? expandedTocs.delete(item.key) : expandedTocs.add(item.key)"> | ||
| <summary :class="{ | ||
| 'toc-content' : item.level==0, | ||
| 'nested' : item.level> | ||
| 0, | ||
| 'current-section': currentPage.some(p => p.key == item.key), | ||
| 'current-section': currentPage.some(p => JSON.stringify(p.keys) == JSON.stringify(item.keys)), |
There was a problem hiding this comment.
It seems that in other places we're using the first key of a page as something of a canonical key for a page. Can we not just use the first key here as well rather than repeatedly stringifying arrays? (and likewise for other occurrences below)
There was a problem hiding this comment.
That definitely makes sense. My reasoning behind trying to find another implementation is I didn't want to assume Keys was non-empty. My only other idea is to add a helper function to check the arrays length then return first element otherwise null, but I wasn't sure if that was the best implementation. Is that what you're thinking for a better alternative?
Also, it's super cool to get feedback from the main maintainer of Coalesce. It's one of my favorite technologies/ideas, maybe aside from LINQ. So yeah, it's cool to virtually meet you :)
There was a problem hiding this comment.
Shouldn't it be invalid for a page to not have any keys? Should add a check for that when building up the TOC data and throw if there is such a page. Then we know its always safe to grab the first key.
Joshua-Lester3
temporarily deployed
to
BuildAndUploadImage
GitHub Actions
Inactive
Joshua-Lester3
temporarily deployed
to
BuildAndUploadImage
GitHub Actions
Inactive
Joshua-Lester3
temporarily deployed
to
BuildAndUploadImage
GitHub Actions
Inactive
Description
Adding support for new Tooling side update: adjusting from
SiteMapping.KeytoKeysas well as sorting byOrderOnPagesince the new Tooling update changes how sitemap.json is ordered.Ensure that your pull request has followed all the steps below: