Ensure forceSync is provided when constructing chunk coordinators #3657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
dordsor21
commented
Jun 7, 2022
•
dordsor21
commented
- Fixes asyncCatchOp errors due to chunk coordinators defaulting to forceSync "true"
- Details that forceSync is not necessarily synchronous to the server main thread, and instead sets that enqueue/start methods are synchronous (blocking)
- Fixes Async catcher prevents plot clear #3667
dordsor21
added
Major bug fix
NotMyFault
reviewed
Jun 7, 2022
Core/src/main/java/com/plotsquared/core/queue/ChunkCoordinatorBuilder.java
Show resolved
Hide resolved
NotMyFault
approved these changes
Jun 7, 2022
2 tasks
SirYwell
approved these changes
Jun 11, 2022
NotMyFault
added
Ready for merge
and removed
Priority
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.