Explicit mention of parameter value for unite_imu_method
#2551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is confusion regarding what value needs to be passed to `unite_imu_method`. The `ros2-development` branch expects a different value for the `unite_imu_method` parameter as compared to the `ros2-legacy` and `ros1-legacy` branches. I have added this detail in the README. Thanks to @Nir-Az for pointing this out in [this](IntelRealSense#2542 (comment)) issue.
Nir-Az
reviewed
Nov 20, 2022
Changes made as suggested by @Nir-Az
|
@Nir-Az I have made the changes and committed. Please have a look into it. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is confusion regarding what value needs to be passed to
unite_imu_method. Theros2-developmentbranch expects a different value for theunite_imu_methodparameter as compared to theros2-legacyandros1-legacybranches. I have added this detail in the README.Thanks to @Nir-Az for pointing this out in this issue.