Fix Viewer GUI freeze due to DFU and SW update pop ups interference #7493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nir-Az
changed the title
ev-mp
changed the title
Nir-Az
force-pushed
the
viewer_freeze_on_dfu
branch
from
87c0e1b to
a4ac21f
Compare
dorodnic
reviewed
Oct 6, 2020
maloel
reviewed
Oct 11, 2020
common/viewer.h
Outdated
| @@ -179,6 +179,7 @@ namespace rs2 | |||
| bool show_help_screen = false; | |||
| bool occlusion_invalidation = true; | |||
| bool glsl_available = false; | |||
| bool expended_notification_on = false; | |||
There was a problem hiding this comment.
call it what it is: modal_notification and if there's confusion: // a notification which was expanded
maloel
reviewed
Oct 11, 2020
common/notifications.cpp
Outdated
| { | ||
| bool expended_notification_found = false; |
maloel
reviewed
Oct 11, 2020
common/updates-model.cpp
Outdated
| // Verify an error window will not pop up. ImGui cannot handle 2 PopUpModals in parallel. | ||
| if (!error_message.empty()) | ||
| { | ||
| LOG_ERROR("error catched during update process, details: " + error_message); |
maloel
reviewed
Oct 11, 2020
Nir-Az
force-pushed
the
viewer_freeze_on_dfu
branch
from
a4ac21f to
5a71d0e
Compare
maloel
approved these changes
Oct 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both processes try to open a popup modal from the same popup tree level,
ImGui does not support it.
Action taken:
Fix issue [RS5-8934]