dds config tool repair #13681
dds config tool repair #13681
Conversation
Noy-Zini
force-pushed
the
viewer-dds-config-tool-repair
branch
from
c20bd3c to
2289871
Compare
Noy-Zini
force-pushed
the
viewer-dds-config-tool-repair
branch
2 times, most recently
from
4fbc5d8 to
97b51f5
Compare
Noy-Zini
force-pushed
the
viewer-dds-config-tool-repair
branch
from
97b51f5 to
07bbd98
Compare
common/dds-model.cpp
Outdated
| @@ -15,6 +18,12 @@ using namespace rs2; | |||
| using rsutils::json; | |||
| using rsutils::type::ip_address; | |||
|
|
|||
| uint32_t const GET_ETH_CONFIG = 0xBB; | |||
There was a problem hiding this comment.
Better that the constants will be declared as static. in this specific case probably does not matter, but it's a "best practice".
static will tell the compiler that the constants are declared for this compilation unit only (this file) and they won't clash with other similarly named symbols in the symbol table.
Another way to do it is to declare them in a nameless namespace.
namespace {
uint32_t const GET_ETH_CONFIG = 0xBB;
....
}
There was a problem hiding this comment.
I saw we mainly use namespace, so I chose to use that unfortunately it affects all of the file and shows all of it in the diff.
There was a problem hiding this comment.
I saw we mainly use namespace, so I chose to use that unfortunately it affects all of the file and shows all of it in the diff.
There was a problem hiding this comment.
You can close the namespace after the constants definition, not at the end of file, this way rest of file won't be changed.
What actually happens is that the compiler internally generates a name and a using statement that uses that name.
…y-Zini/librealsense into viewer-dds-config-tool-repair
I added a scroll bar to the settings window 👍 |
Noy-Zini
force-pushed
the
viewer-dds-config-tool-repair
branch
from
6d8d339 to
5a622f1
Compare
Noy-Zini
force-pushed
the
viewer-dds-config-tool-repair
branch
from
5a622f1 to
b11b18f
Compare
Fix according to comments on PR #13628
Tracked on : [RSDEV-2884]