Test waiting on #10990
Merged
Test waiting on #10990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nir-Az
reviewed
Oct 13, 2022
Nir-Az
reviewed
Oct 13, 2022
| @@ -162,5 +162,9 @@ TEST_CASE( "Not invoked flush timeout expected" ) | |||
| invoked.wait_until( timeout, [&]() { return invoked; } ); | |||
| auto wait_time = sw.get_elapsed(); | |||
|
|
|||
| INFO( wait_time.count() ); | |||
| INFO( timeout.count() ); | |||
There was a problem hiding this comment.
What is the difference between
wait_time and wait_time.count()?
There was a problem hiding this comment.
No difference. Fixed it and pushed a new commit.
Nir-Az
approved these changes
Oct 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added to the last test case 4 lines in order to receive more information when the test fails