Add live fps test #10591
Merged
Add live fps test #10591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to testing # Conflicts: # unit-tests/live/frames/test-fps.py
maloel
reviewed
Jun 19, 2022
unit-tests/live/frames/test-fps.py
Outdated
| test.start("Testing color fps " + product_line + " device - "+ platform.system() + " OS") | ||
|
|
||
| for requested_fps in tested_fps: | ||
| dev = test.find_first_device_or_exit() |
maloel
reviewed
Jun 19, 2022
| dev = test.find_first_device_or_exit() | ||
| cs = dev.first_color_sensor() | ||
| if product_line == "D400": | ||
| ds.set_option(rs.option.enable_auto_exposure, 1) |
|
You meant explain in a comment on the code or in the PR?
From: Eran ***@***.***>
Sent: Sunday, June 19, 2022 12:55
To: IntelRealSense/librealsense ***@***.***>
Cc: Meir, Ohad1 ***@***.***>; Author ***@***.***>
Subject: Re: [IntelRealSense/librealsense] Add live fps test (PR #10591)
@maloel commented on this pull request.
________________________________
In unit-tests/live/frames/test-fps.py<#10591 (comment)>:
+ print("Requested fps: {:.1f} [Hz], not supported".format(requested_fps))
+ else:
+ fps = measure_fps(ds, dp)
+ print("Requested fps: {:.1f} [Hz], actual fps: {:.1f} [Hz] ".format(requested_fps, fps))
+ test.check(fps <= (requested_fps + acceptable_exception_rate_Hz) and fps >= (requested_fps - acceptable_exception_rate_Hz))
+test.finish()
+
+
+#####################################################################################################
+test.start("Testing color fps " + product_line + " device - "+ platform.system() + " OS")
+
+for requested_fps in tested_fps:
+ dev = test.find_first_device_or_exit()
+ cs = dev.first_color_sensor()
+ if product_line == "D400":
+ ds.set_option(rs.option.enable_auto_exposure, 1)
Please explain
—
Reply to this email directly, view it on GitHub<#10591 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AX3PS5UNA2HEHEGMZZKJBQDVP3U6RANCNFSM5YWOOVZA>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
---------------------------------------------------------------------
Intel Israel (74) Limited
This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.
|
maloel
approved these changes
Jun 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a unit test under live/frames to test fps.
Only nightly because run time ~200 seconds for D400 and ~110 seconds for L515