This repository has been archived by the owner on Feb 2, 2024. It is now read-only.
Allow global values to be used in read_csv params (names, usecols) #998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: fixes a bug in RewriteReadCsv rewrite that fails compilation when exception is raised during the match phase because variable defining value of read_csv parameter is not ir.Expr node but ir.Global (and thus has no op attribute).
PokhodenkoSA
reviewed
Dec 6, 2021
There was a problem hiding this comment.
@kozlov-alexey
Please, do not add me to review. I didn't develop anything for SDC for a long time now.
AlexanderKalistratov
approved these changes
Dec 6, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation: fixes a bug in RewriteReadCsv rewrite that fails compilation
when exception is raised during the match phase because variable
defining value of read_csv parameter is not ir.Expr node but ir.Global
(and thus has no op attribute).