Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QueryHandler doesn't really check individual command return status #107

Open
vishakha041 opened this issue May 15, 2019 · 1 comment
Open

QueryHandler doesn't really check individual command return status #107

vishakha041 opened this issue May 15, 2019 · 1 comment
Labels
Bug Indicates unexpected or undesired behaviors Discussion Needed Require additional context and discussion Priority: Backlog Tasks that are not pressing, but to be tracked and revisited

Comments

@vishakha041
Copy link
Contributor

Line 398 in src/QueryHandler.cc which checks for "status" entry in response JSON seems to essentially be a no-op since it does not descend into any command structure. You have to index into the data structure with the command name if you actually want to check status per command.
@vishakha041 vishakha041 added Bug Indicates unexpected or undesired behaviors good first issue labels May 15, 2019
cwlacewe added a commit to cwlacewe/vdms that referenced this issue Apr 14, 2023
@cwlacewe
Fix snyk vulnerability (IntelLabs#107)
acffe32 
* Update dockerfiles to pass snyk locally
@ifadams
Copy link
Contributor

ifadams commented Jul 23, 2024

@cwlacewe this might want to be bumped in priority. We generally have issues with lack of clarity/good error handling.

@ifadams ifadams added Discussion Needed Require additional context and discussion Priority: Backlog Tasks that are not pressing, but to be tracked and revisited and removed good first issue labels Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Indicates unexpected or undesired behaviors Discussion Needed Require additional context and discussion Priority: Backlog Tasks that are not pressing, but to be tracked and revisited
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ifadams @luisremis @vishakha041