Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speedup adversarial training with a simple perturber #89

Merged
merged 28 commits into from
Mar 9, 2023

Conversation

mzweilin
Copy link
Contributor

@mzweilin mzweilin commented Mar 2, 2023

What does this PR do?

This PR makes the example adversarial training task python -m mart experiment=CIFAR10_CNN_Adv 1.92x faster (400 seconds over 769 seconds).

Batch perturber: 769 seconds, 47% GPU-util
Simple perturber: 434 seconds, 77% GPU-util
Simple perturber and simple threat model: 400 seconds, 82% GPU-util

Adversarial training is slow because MART tries to keep track of each input example in one NCHW batch, resulting in running gradient_modifier and projector and enforcing threat_model separately.

This is not necessary for the simple FGSM attack in adversarial training.

Replacing with a simple Perturber that represents perturbations in the NCHW format enables batching gradient_modifier, projector and threat_model efficiently.

Type of change

Please check all relevant options.

  • Improvement (non-breaking)
  • Bug fix (non-breaking)
  • New feature (non-breaking)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Testing

Please describe the tests that you ran to verify your changes. Consider listing any relevant details of your test configuration.

  • tests/test_adversary.py::test_adversary_perturber_hidden_params
  • tests/test_adversary.py::test_adversary_perturbation

Before submitting

  • The title is self-explanatory and the description concisely explains the PR
  • My PR does only one thing, instead of bundling different changes together
  • I list all the breaking changes introduced by this pull request
  • I have commented my code
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have run pre-commit hooks with pre-commit run -a command without errors

Did you have fun?

Make sure you had fun coding 🙃

@mzweilin mzweilin requested a review from dxoigmn March 2, 2023 01:27
Copy link
Contributor

@dxoigmn dxoigmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments.

@dxoigmn

This comment was marked as resolved.

@mzweilin mzweilin changed the title Speedup Adversarial Training with EntiretyPerturber Speedup adversarial training with a simple perturber Mar 6, 2023
@dxoigmn dxoigmn self-requested a review March 8, 2023 20:10
dxoigmn
dxoigmn previously approved these changes Mar 8, 2023
Copy link
Contributor

@dxoigmn dxoigmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dxoigmn dxoigmn self-requested a review March 8, 2023 20:18
dxoigmn
dxoigmn previously approved these changes Mar 8, 2023
Copy link
Contributor

@dxoigmn dxoigmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dxoigmn

This comment was marked as resolved.

@mzweilin mzweilin requested a review from dxoigmn March 8, 2023 23:05
Copy link
Contributor

@dxoigmn dxoigmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments.

@mzweilin mzweilin requested a review from dxoigmn March 9, 2023 00:02
Copy link
Contributor

@dxoigmn dxoigmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mzweilin mzweilin merged commit adb9399 into main Mar 9, 2023
@mzweilin mzweilin deleted the entirety_perturber branch March 9, 2023 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants