Allow empty program error messages. #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
mzweilin
added a commit
that referenced
this pull request
Feb 6, 2023
mzweilin
added a commit
that referenced
this pull request
Feb 6, 2023
* Allow --resume without other parameters. * Add a resume test. * Make failed experiments capturable. * Move extra overrides to the pseudo task folder. * Test if resume happens before modifying configs. * Capture stdout in test. * Resume and modify cfg before any other change is made. * Remove color in console output for testing. * Make imports consistent. * Install optinal dependency in CI. * Replace strip_ansi with _tty_out=False. * Revert "Replace strip_ansi with _tty_out=False." This reverts commit 589df6b. * Avoid parsing program output by disabling timestamp in the output path. * Switch from MULTIRUN to RUN. * Return -1 if not runable. * Allow empty error messages. * NO_COLOR=1 in terminal output during tests. * Remove dependency strip_ansi. * Separate changes to #59. * Separate changes to #61 and #62. * Move the code closer. * Comment. * Move sys.ext() out of main(). * Remove unused import.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
We want
pytestto detect non-zero return value of a program and fail a test, but the previous code will ignore the error if the message is empty. The fix allows failing a test with an empty error message.Type of change
Please check all relevant options.
Testing
Please describe the tests that you ran to verify your changes. Consider listing any relevant details of your test configuration.
Before submitting
pre-commit run -acommand without errorsDid you have fun?
Make sure you had fun coding 🙃