Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GroupNorm32 to __all__ statement in nn.py #45

Merged

Conversation

lumurillo
Copy link
Contributor

What does this PR do?

Fixes #33

Type of change

Please check all relevant options.

  • Improvement (non-breaking)
  • Bug fix (non-breaking)
  • New feature (non-breaking)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Testing

Please describe the tests that you ran to verify your changes. Consider listing any relevant details of your test configuration.

  • pytest --cov=mart

Before submitting

  • The title is self-explanatory and the description concisely explains the PR
  • My PR does only one thing, instead of bundling different changes together
  • I list all the breaking changes introduced by this pull request
  • I have commented my code
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have run pre-commit hooks with pre-commit run -a command without errors

Did you have fun?

Make sure you had fun coding 🙃

@lumurillo lumurillo requested a review from mzweilin January 10, 2023 17:13
@lumurillo lumurillo self-assigned this Jan 10, 2023
@dxoigmn dxoigmn requested review from dxoigmn and removed request for mzweilin January 19, 2023 00:10
@lumurillo lumurillo merged commit 48bdf50 into main Jan 19, 2023
@lumurillo lumurillo deleted the lumurillo/33-change-martnnnngroupnorm32-to-martnngroupnorm32 branch January 19, 2023 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change mart.nn.nn.GroupNorm32 to mart.nn.GroupNorm32
2 participants