Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add _call_ special arg to SequentialDict #184

Merged
merged 37 commits into from
Jun 28, 2023
Merged

Conversation

dxoigmn
Copy link
Contributor

@dxoigmn dxoigmn commented Jun 27, 2023

What does this PR do?

This PR enables one to call other methods besides __call__ in sequences. For example, in the snippet below one could directly call MyModel.forward in seq010

modules:
  model:
    _target_: MyModel

training_sequence:
  seq010.forward:
    model:
      images: "input"
      targets: "target.list_of_targets"

Type of change

Please check all relevant options.

  • Improvement (non-breaking)
  • Bug fix (non-breaking)
  • New feature (non-breaking)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Testing

Please describe the tests that you ran to verify your changes. Consider listing any relevant details of your test configuration.

  • pytest
  • CUDA_VISIBLE_DEVICES=0 python -m mart experiment=CIFAR10_CNN_Adv trainer=gpu trainer.precision=16 reports 70% (21 sec/epoch).
  • CUDA_VISIBLE_DEVICES=0,1 python -m mart experiment=CIFAR10_CNN_Adv trainer=ddp trainer.precision=16 trainer.devices=2 model.optimizer.lr=0.2 trainer.max_steps=2925 datamodule.ims_per_batch=256 datamodule.world_size=2 reports 70% (14 sec/epoch).

Before submitting

  • The title is self-explanatory and the description concisely explains the PR
  • My PR does only one thing, instead of bundling different changes together
  • I list all the breaking changes introduced by this pull request
  • I have commented my code
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have run pre-commit hooks with pre-commit run -a command without errors

Did you have fun?

Make sure you had fun coding 🙃

@dxoigmn dxoigmn requested a review from mzweilin June 27, 2023 14:57
@dxoigmn dxoigmn marked this pull request as ready for review June 27, 2023 14:57
@dxoigmn dxoigmn mentioned this pull request Jun 27, 2023
20 tasks
mzweilin
mzweilin previously approved these changes Jun 27, 2023
Copy link
Contributor

@mzweilin mzweilin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dxoigmn dxoigmn changed the title Enable the ability to call other module methods in sequences. Enable the ability to call other module methods in sequences via _call_ or dot syntax Jun 28, 2023
@dxoigmn dxoigmn changed the base branch from better_sequentialdict4 to main June 28, 2023 15:13
@dxoigmn dxoigmn dismissed mzweilin’s stale review June 28, 2023 15:13

The base branch was changed.

@dxoigmn dxoigmn changed the title Enable the ability to call other module methods in sequences via _call_ or dot syntax Add _call_ special args to SequentialDict Jun 28, 2023
@dxoigmn dxoigmn changed the title Add _call_ special args to SequentialDict Add _call_ special arg to SequentialDict Jun 28, 2023
@dxoigmn dxoigmn merged commit 5475ec3 into main Jun 28, 2023
@dxoigmn dxoigmn deleted the better_sequentialdict5 branch June 28, 2023 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants