generated from ashleve/lightning-hydra-template
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade template 1.4.0->2.0.2 #157
Draft
mzweilin
wants to merge
24
commits into
main
Choose a base branch
from
upgrade_template_2.0.2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
--- updated-dependencies: - dependency-name: torch dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>
16 tasks
I should note that it looks like torchmetrics 1.0 will be released soon and that will re-include the mAP implementation that uses cocoapi. See: https://github.com/Lightning-AI/torchmetrics/milestone/13 |
torchmetrics 1.0 has been released! Upgrade all the dependencies! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Upgrade to the latest template 2.0.2 at https://github.com/ashleve/lightning-hydra-template
Changes
pre-commit
datamodule
->data
cpu
trainer configsrc.tasks
tosrc
src.utils.utils
into several .py filesaim
as a logger.gitignore
for theaim
loggerAlready included (or with newer versions) in #192
torch ~= 1.13.1
->torch ~= 2.0.1
pytorch-lightning ~= 1.6.5
->lightning ~= 2.0.2
torchmetrics == 0.6.0
->torchmetrics == 0.11.4
(newer PL requires torchmetrics>0.6.0)lightning.fabric
for TPU[Resolved] The PR depends on Lightning-AI/torchmetrics#1024
We won't upgrade
torchmetrics
until they fix mAP.Type of change
Please check all relevant options.
Testing
Please describe the tests that you ran to verify your changes. Consider listing any relevant details of your test configuration.
pytest
Before submitting
pre-commit run -a
command without errorsDid you have fun?
Make sure you had fun coding 🙃