Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade template 1.4.0->2.0.2 #157

Draft
wants to merge 24 commits into
base: main
Choose a base branch
from
Draft

Upgrade template 1.4.0->2.0.2 #157

wants to merge 24 commits into from

Conversation

mzweilin
Copy link
Contributor

@mzweilin mzweilin commented Jun 6, 2023

What does this PR do?

Upgrade to the latest template 2.0.2 at https://github.com/ashleve/lightning-hydra-template

Changes

  • upgrade to hydra 1.3
  • upgrade toolkits in pre-commit
  • config datamodule -> data
  • add a cpu trainer config
  • move src.tasks to src
  • stop exporting extra log after a task exception.
  • split src.utils.utils into several .py files
  • add aim as a logger
  • update .gitignore for the aim logger

Already included (or with newer versions) in #192

  • torch ~= 1.13.1 -> torch ~= 2.0.1
  • pytorch-lightning ~= 1.6.5 -> lightning ~= 2.0.2
  • torchmetrics == 0.6.0 -> torchmetrics == 0.11.4 (newer PL requires torchmetrics>0.6.0)
  • use lightning.fabric for TPU

[Resolved] The PR depends on Lightning-AI/torchmetrics#1024
We won't upgrade torchmetrics until they fix mAP.

Type of change

Please check all relevant options.

  • Improvement (non-breaking)
  • Bug fix (non-breaking)
  • New feature (non-breaking)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Testing

Please describe the tests that you ran to verify your changes. Consider listing any relevant details of your test configuration.

  • pytest

Before submitting

  • The title is self-explanatory and the description concisely explains the PR
  • My PR does only one thing, instead of bundling different changes together
  • I list all the breaking changes introduced by this pull request
  • I have commented my code
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have run pre-commit hooks with pre-commit run -a command without errors

Did you have fun?

Make sure you had fun coding 🙃

@mzweilin mzweilin marked this pull request as draft June 6, 2023 00:24
@mzweilin mzweilin mentioned this pull request Jun 22, 2023
16 tasks
@dxoigmn
Copy link
Contributor

dxoigmn commented Jun 22, 2023

I should note that it looks like torchmetrics 1.0 will be released soon and that will re-include the mAP implementation that uses cocoapi. See: https://github.com/Lightning-AI/torchmetrics/milestone/13

@dxoigmn
Copy link
Contributor

dxoigmn commented Jul 5, 2023

torchmetrics 1.0 has been released! Upgrade all the dependencies!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants