Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better Perturber #146

Merged
merged 25 commits into from
Jun 1, 2023
Merged

Better Perturber #146

merged 25 commits into from
Jun 1, 2023

Conversation

dxoigmn
Copy link
Contributor

@dxoigmn dxoigmn commented May 5, 2023

What does this PR do?

This PR GradientModifier from the Perturber and into the Adversary.

Type of change

Please check all relevant options.

  • Improvement (non-breaking)
  • Bug fix (non-breaking)
  • New feature (non-breaking)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Testing

Please describe the tests that you ran to verify your changes. Consider listing any relevant details of your test configuration.

  • pytest
  • python -m mart experiment=CIFAR10_CNN_Adv trainer=gpu achieves 71% accuracy.

Before submitting

  • The title is self-explanatory and the description concisely explains the PR
  • My PR does only one thing, instead of bundling different changes together
  • I list all the breaking changes introduced by this pull request
  • I have commented my code
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have run pre-commit hooks with pre-commit run -a command without errors

Did you have fun?

Make sure you had fun coding 🙃

@dxoigmn dxoigmn changed the base branch from main to iterable_instead_of_tuple May 5, 2023 19:07
@dxoigmn dxoigmn changed the title Better perturber Better Perturber May 5, 2023
@dxoigmn dxoigmn mentioned this pull request May 5, 2023
20 tasks
Base automatically changed from iterable_instead_of_tuple to main May 16, 2023 15:57
@dxoigmn dxoigmn marked this pull request as ready for review May 16, 2023 18:16
@dxoigmn dxoigmn requested a review from mzweilin May 16, 2023 18:16
This was referenced May 16, 2023
Copy link
Contributor

@mzweilin mzweilin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see inline comments.

Copy link
Contributor

@mzweilin mzweilin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dxoigmn dxoigmn merged commit 7551779 into main Jun 1, 2023
@dxoigmn dxoigmn deleted the better_perturber branch June 1, 2023 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants