Replace tuple with Iterable[torch.Tensor] #134
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
We had type annotations for
tuple
everywhere, but this is not great because it doesn't tell us what is inside of thetuple
. As such, I changed it toIterable[torch.Tensor]
. I also tried to cleanup the dispatch code in all places. This PR, however, does not support input dictionaries right now. I think the "modality dispatch" abstraction in #115 should be pulled out and rebased on this PR.Type of change
Please check all relevant options.
Testing
Please describe the tests that you ran to verify your changes. Consider listing any relevant details of your test configuration.
make test
Before submitting
pre-commit run -a
command without errorsDid you have fun?
Make sure you had fun coding 🙃