Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build wheels on main branch for linux/arm64 #630

Merged
merged 6 commits into from
Jan 28, 2022
Merged

Conversation

zsol
Copy link
Member

@zsol zsol commented Jan 26, 2022

Summary

Test Plan

In this commit I enabled running the arm builds on this PR only. That commit is removed before merging.
See https://github.com/Instagram/LibCST/actions/runs/1752265369 for an example run.

Should help address #603.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 26, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jan 26, 2022

Codecov Report

Merging #630 (30d0718) into main (595d8c3) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #630   +/-   ##
=======================================
  Coverage   94.78%   94.78%           
=======================================
  Files         245      245           
  Lines       25281    25281           
=======================================
  Hits        23963    23963           
  Misses       1318     1318           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 595d8c3...30d0718. Read the comment docs.

@zsol zsol force-pushed the ci/linux-arm branch 6 times, most recently from a6e72c6 to 7721c86 Compare January 26, 2022 17:18
@zsol zsol marked this pull request as ready for review January 26, 2022 19:09
@zsol zsol requested a review from lpetre January 26, 2022 21:06
Copy link
Contributor

@lpetre lpetre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants