[scope] keep track of assignment/access ordering #413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
jimmylai
reviewed
Nov 5, 2020
jimmylai
reviewed
Nov 10, 2020
jimmylai
reviewed
Nov 10, 2020
libcst/metadata/scope_provider.py
Outdated
Comment on lines
139
to
141
| if earlier_accesses != set() and self.scope.parent != self.scope: | ||
| for shadowed_assignment in self.scope.parent[self.name]: | ||
| shadowed_assignment.record_accesses(earlier_accesses) |
There was a problem hiding this comment.
NVM, I got it. It's to handle the accesses not part of later access. Add them to parent assignments make sense.
There was a problem hiding this comment.
I used to have a comment here, it might've got lost during rebases. I'll add it back
jimmylai
approved these changes
Nov 10, 2020
thatch
reviewed
Nov 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR makes sure references are never attached to assignments that are declared later than the access (but still in the same scope). It does so by keeping track of the relative ordering of accesses to assignments, through the inclusion of an
__indexmember in both. The idea is to increment the index every time an assignment "happens" in a scope. This is a bit tricky because fora = b, the right hand side cannot refer to variables on the left side even if the left side is visited first.Fixes #326
Test Plan
Added extensive test case for a variable shadowing in a class/global scope scenario.