Fix some IGCollectionView unavaliable methods hint #479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rnystrom When using IGListKit, I found some documents a little misleading. |
jessesquires
approved these changes
Feb 10, 2017
There was a problem hiding this comment.
Thanks @PhilCai1993 ! 💯
These were lost in an older refactor. Good catch. 😎
cc @rnystrom to double-check these APIs
|
@PhilCai1993 you're a master of details, I love it. Thank you again! |
|
@rnystrom has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
Pull request checklist
CHANGELOG.mdfor any breaking changes, enhancements, or bug fixes.I guess there's some mistake in unavailable hints