Update deployment targets to silence Xcode 14 warnings #1573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xcode 14 doesn't support deploying to older versions and shows a warning on every build
|
@TimOliver has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
Hi @ksuther! Thanks for the PR! (And on a personal note, I'm a huge fan of Fantastical!) I've imported the PR and I'm updating the We actually hadn't discussed bumping the minimum version of iOS 9 to iOS 11 yet. Given this library is feature complete for iOS 9, I'd love to keep it as-is, but I'm getting the feeling that Xcode 14 has officially deprecated iOS 9 on our behalf. Once I hear back from the rest of the IGListKit team, I'll go ahead and merge this. Thanks again! |
|
Thank you (and happy to hear that)! Apple threw every stable library a curve ball this year with Xcode 14, unfortunately. |
|
@TimOliver merged this pull request in 3cd3a11. |
4 tasks
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 12, 2023
Summary: ## Changes in this pull request Xcode 15 has moved the iOS deployment target up to iOS 12 (just like #1573 for Xcode 14). I did not modify the changelog because there's already an entry there for iOS 11 and macOS 10.13. This also includes a build error fix for IGWarnAssert (dffcd4d). I tried running the unit tests but a number of them are failing from previous changes. ### Checklist - [ ] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [ ] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/main/.github/CONTRIBUTING.md) Pull Request resolved: #1589 Reviewed By: fabiomassimo Differential Revision: D50013207 Pulled By: TimOliver fbshipit-source-id: 6c7a7b2ca3dd1265f11e85979432eded3292ed06
GreeMoz
pushed a commit
to appintheair/IGListKit
that referenced
this pull request
Jan 31, 2024
Summary: ## Changes in this pull request Xcode 14 changed the minimum deployment target to iOS/tvOS 11.0 and macOS 10.13. This PR moves up the deployment targets so that a warning isn't shown on every build. I also silenced the development region and base localization warnings. ### Checklist - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/main/.github/CONTRIBUTING.md) Pull Request resolved: Instagram#1573 Differential Revision: D45223095 Pulled By: TimOliver fbshipit-source-id: 57fbd284809c09f86a9731d0676332de35fbe0df
GreeMoz
pushed a commit
to appintheair/IGListKit
that referenced
this pull request
Jan 31, 2024
…1589) Summary: ## Changes in this pull request Xcode 15 has moved the iOS deployment target up to iOS 12 (just like Instagram#1573 for Xcode 14). I did not modify the changelog because there's already an entry there for iOS 11 and macOS 10.13. This also includes a build error fix for IGWarnAssert (dffcd4d). I tried running the unit tests but a number of them are failing from previous changes. ### Checklist - [ ] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [ ] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/main/.github/CONTRIBUTING.md) Pull Request resolved: Instagram#1589 Reviewed By: fabiomassimo Differential Revision: D50013207 Pulled By: TimOliver fbshipit-source-id: 6c7a7b2ca3dd1265f11e85979432eded3292ed06
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
Xcode 14 changed the minimum deployment target to iOS/tvOS 11.0 and macOS 10.13. This PR moves up the deployment targets so that a warning isn't shown on every build.
I also silenced the development region and base localization warnings.
Checklist
CHANGELOG.mdfor any breaking changes, enhancements, or bug fixes.