Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove useless system version code #1396

Closed
wants to merge 2 commits into from
Closed

Remove useless system version code #1396

wants to merge 2 commits into from

Conversation

kinarobin
Copy link
Contributor

@kinarobin kinarobin commented Nov 21, 2019 •
edited
Loading

Changes in this pull request

Examples/Examples-iOS/Pods/Pods.xcodeproj/project.pbxproj
Examples/Examples-tvOS/Pods/Pods.xcodeproj/project.pbxproj

this change just Xcode 11.2 generated.

This pr aim to remove useless IGSystemVersion file.

Checklist

  • All tests pass. Demo project builds and runs.
  • I added tests, an experiment, or detailed why my change isn't tested.
  • I added an entry to the CHANGELOG.md for any breaking changes, enhancements, or bug fixes.
  • I have reviewed the contributing guide

@iglistkit-bot
Copy link

iglistkit-bot commented Nov 21, 2019 •
edited
Loading

3 Warnings
⚠️ Big PR
⚠️ All pull requests should have a milestone attached, unless marked #trivial.
⚠️ Adding or removing library source files requires updating the examples. Please run ./scripts/pod_setup.sh from the root directory and commit the changes.

Generated by 🚫 Danger

iperry90
iperry90 approved these changes Nov 21, 2019
View reviewed changes
Copy link

@iperry90 iperry90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for removing this!

facebook-github-bot
facebook-github-bot reviewed Nov 21, 2019
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iperry90 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@iperry90 merged this pull request in 7fe113f.

@kinarobin kinarobin deleted the remove_useless_system_version branch November 22, 2019 03:50
@barakwei barakwei mentioned this pull request Aug 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@iperry90 iperry90 iperry90 approved these changes

Assignees
No one assigned
Labels
CLA Signed Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kinarobin @iglistkit-bot @facebook-github-bot @iperry90