Change paths to path #1205
Closed
Change paths to path #1205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rnystrom
suggested changes
Jul 9, 2018
|
@rnystrom Done 😊 |
|
@rnystrom @jessesquires After adding the test, I find this bug isn't that trivial😆. Should I add a changelog for it? |
|
@zhubofei yes please! I need to do a deeper audit to make sure this doesn't break anything haha. |
4 tasks
|
@zhubofei Thanks for the fix, what I dont understand is that it seems like the current production code is not affected by this bug at all, do u have any theory why this is the case? |
There was a problem hiding this comment.
@lorixx has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
There was a problem hiding this comment.
@lorixx has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
Should map be a map of
IndexPaths instead of arrays ofIndexPaths? Also, we might need some unit tests on this part. I don't think it's covered.Checklist
CHANGELOG.mdfor any breaking changes, enhancements, or bug fixes.