Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renaming "withCollectionView:" param to "collectionView:" in IGListAdapterUpdaterDelegate #466

Closed
rnystrom opened this issue Feb 6, 2017 · 0 comments
Closed

Renaming "withCollectionView:" param to "collectionView:" in IGListAdapterUpdaterDelegate #466

rnystrom opened this issue Feb 6, 2017 · 0 comments
Labels
enhancement starter-task
Milestone
3.0.0

Comments

@rnystrom
Copy link
Contributor

rnystrom commented Feb 6, 2017

In the updater delegate protocol, this method:

- (void)listAdapterUpdater:(IGListAdapterUpdater *)listAdapterUpdater 
  didPerformBatchUpdates:(IGListBatchUpdateData *)updates 
  withCollectionView:(UICollectionView *)collectionView;

Should read

- (void)listAdapterUpdater:(IGListAdapterUpdater *)listAdapterUpdater 
  didPerformBatchUpdates:(IGListBatchUpdateData *)updates 
  collectionView:(UICollectionView *)collectionView;

To be consistent with the rest of the protocol. Note this is a breaking change.
@rnystrom rnystrom added this to the 3.0.0 milestone Feb 6, 2017
@rnystrom rnystrom mentioned this issue Feb 6, 2017
Closed
11 tasks
@vincent-peng vincent-peng mentioned this issue Feb 14, 2017
Closed
4 tasks
@Malecks Malecks mentioned this issue Feb 21, 2017
Closed
4 tasks
facebook-github-bot pushed a commit that referenced this issue Feb 21, 2017
@facebook-github-bot
Rename "withCollectionView:" param to "collectionView:"
2adea72 
Summary:
- Rename "withCollectionView:" param to "collectionView:" param to be consistent with the rest
of the protocol.
- Update tests.

Related issue: #466

- [x] All tests pass. Demo project builds and runs.
- [ ] I added tests, an experiment, or detailed why my change isn't tested.
- [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes.
- [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md)
Closes #491

Differential Revision: D4589976

Pulled By: rnystrom

fbshipit-source-id: 5e5aa7328a6bbac6baa705d5228f0eb4321d8c31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement starter-task
Projects
None yet
Milestone
3.0.0
Development

Successfully merging a pull request may close this issue.

Rename withCollectionView param to collectionView in IGListAdapterUpdaterDelegate. Malecks/IGListKit
1 participant
@rnystrom