Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert as many NSUInteger to NSInteger as possible #431

Closed
rnystrom opened this issue Jan 18, 2017 · 0 comments
Closed

Convert as many NSUInteger to NSInteger as possible #431

rnystrom opened this issue Jan 18, 2017 · 0 comments
Labels
enhancement starter-task
Milestone
3.0.0

Comments

@rnystrom
Copy link
Contributor

https://github.com/Instagram/IGListKit/search?utf8=%E2%9C%93&q=NSUInteger&type=Code

There are some remaining ones. There's really no point to using unsigned ints internally even. Let's avoid the eventual UINT_MAX bug here.
@jessesquires jessesquires added this to the 3.0.0 milestone Jan 20, 2017
@zhubofei zhubofei mentioned this issue Jan 22, 2017
Closed
1 task
@zhubofei zhubofei modified the milestones: 2.2.0, 3.0.0 Jan 22, 2017
facebook-github-bot pushed a commit that referenced this issue Feb 11, 2017
@jessesquires @facebook-github-bot
fix integer type inconsistency, potential over/underflow
7d55bd8 
Summary:
Internal crash reports (see T15774792) indicate we're having integer overflow/underflow issues.
I notcied this inconsistency, which was introduced by GH issues #431, #440.

Differential Revision: D4546852

fbshipit-source-id: 67e56487cce02f082943f3008bcfcb5cf6205e0e
@jessesquires jessesquires modified the milestones: 2.2.0, 3.0.0 Feb 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement starter-task
Projects
None yet
Milestone
3.0.0
Development

No branches or pull requests
3 participants
@rnystrom @zhubofei @jessesquires