disables prefetchEnabled by default

Instagram · Dec 12, 2016 · 39dbeea · 39dbeea
1 parent fc56c02
commit 39dbeea
Show file tree

Hide file tree

Showing 2 changed files with 33 additions and 1 deletion.
diff --git a/Source/IGListCollectionView.m b/Source/IGListCollectionView.m
@@ -19,11 +19,25 @@ - (instancetype)initWithFrame:(CGRect)frame collectionViewLayout:(UICollectionVi
             self.backgroundColor = [UIColor whiteColor];
         }
 
-        self.alwaysBounceVertical = YES;
+        [self updateIGListCollectionViewDefaultValues];
     }
     return self;
 }
 
+- (instancetype)initWithCoder:(NSCoder *)aDecoder {
+    if (self = [super initWithCoder:aDecoder]) {
+        [self updateIGListCollectionViewDefaultValues];
+    }
+    return self;
+}
+
+- (void)updateIGListCollectionViewDefaultValues {
+    if ([self respondsToSelector:@selector(setPrefetchingEnabled:)]) {
+        self.prefetchingEnabled = NO;
+    }
+    self.alwaysBounceVertical = YES;
+}
+
 - (void)layoutSubviews {
     /**
      UICollectionView will sometimes lay its cells out with an animation. This is especially noticeable on older devices

diff --git a/Tests/IGListCollectionViewTests.m b/Tests/IGListCollectionViewTests.m
@@ -50,6 +50,24 @@ -(void)test_thatIGListCollectionViewHasCorrectDefaults {
     IGListCollectionView *collectionView = [[IGListCollectionView alloc] initWithFrame: kIGListCollectionViewTestFrame collectionViewLayout:[UICollectionViewFlowLayout new]];
 
     XCTAssertTrue(collectionView.alwaysBounceVertical);
+
+    if ([collectionView respondsToSelector:@selector(isPrefetchingEnabled)]) {
+        XCTAssertFalse(collectionView.isPrefetchingEnabled);
+    }
+}
+
+-(void)test_thatStoryboardIGListCollectionViewHasCorrectDefaults {
+    UIWindow *window = [[UIWindow alloc] initWithFrame:kIGListCollectionViewTestFrame];
+    UIStoryboard *storyboard = [UIStoryboard storyboardWithName:@"IGTestStoryboard" bundle:[NSBundle bundleForClass:self.class]];
+    IGTestStoryboardViewController  *viewController = [storyboard instantiateViewControllerWithIdentifier:@"testVC"];
+    [window addSubview:viewController.view];
+    [viewController performSelectorOnMainThread:@selector(loadView) withObject:nil waitUntilDone:YES];
+
+    XCTAssertTrue(viewController.collectionView.alwaysBounceVertical);
+
+    if ([UICollectionView instancesRespondToSelector:@selector(isPrefetchingEnabled)]) {
+        XCTAssertFalse(viewController.collectionView.isPrefetchingEnabled);
+    }
 }
 
 -(void)test_whenUsingUIAppearance_thatStoryboardIGListCollectionViewUsesAppearanceBackgroundColor {