Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow dash in rule names #503

Merged
merged 1 commit into from
Jan 21, 2025
Merged

Allow dash in rule names #503

merged 1 commit into from
Jan 21, 2025

Conversation

zsol
Copy link
Member

@zsol zsol commented Jan 20, 2025

Since rules are dynamically imported, they don't actually have to adhere to identifier naming.

This allows putting rules in directories with - in them.

Since rules are dynamically imported, they don't actually have to adhere to identifier naming.

This allows putting rules in directories with `-` in them.
@zsol zsol requested a review from amyreese as a code owner January 20, 2025 15:23
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 20, 2025
@amyreese amyreese merged commit f053db2 into main Jan 21, 2025
16 checks passed
@amyreese
Copy link
Member

gross but ok 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants