Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test cases covering more lint-ignore directives #442

Merged
merged 2 commits into from
Apr 20, 2024

Conversation

amyreese
Copy link
Member

@amyreese amyreese commented Apr 20, 2024

Stack from ghstack (oldest at bottom):

Add a failing test to demonstrate decorator comment not respected

Add failing test to demonstrate comprehension comments not respected

Add failing test to demonstrate list element comments not respected

More test cases, label and split existing cases

Co-authored-by: Amethyst Reese [email protected]

[ghstack-poisoned]
@amyreese amyreese requested a review from zsol as a code owner April 20, 2024 01:33
amyreese pushed a commit that referenced this pull request Apr 20, 2024
Add a failing test to demonstrate decorator comment not respected

Add failing test to demonstrate comprehension comments not respected

Add failing test to demonstrate list element comments not respected

More test cases, label and split existing cases

Co-authored-by: Amethyst Reese <[email protected]>

ghstack-source-id: a52d089f0aa288cd385dc08507c75e7346ac122c
Pull Request resolved: #442
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 20, 2024
[ghstack-poisoned]
amyreese pushed a commit that referenced this pull request Apr 20, 2024
Add a failing test to demonstrate decorator comment not respected

Add failing test to demonstrate comprehension comments not respected

Add failing test to demonstrate list element comments not respected

More test cases, label and split existing cases

Co-authored-by: Amethyst Reese <[email protected]>

ghstack-source-id: bfaaf6b323dfe87e3d63de0540260b3b122db6eb
Pull Request resolved: #442
@amyreese amyreese merged commit 8b21636 into gh/amyreese/2/base Apr 20, 2024
16 checks passed
amyreese pushed a commit that referenced this pull request Apr 20, 2024
Add a failing test to demonstrate decorator comment not respected

Add failing test to demonstrate comprehension comments not respected

Add failing test to demonstrate list element comments not respected

More test cases, label and split existing cases

Co-authored-by: Amethyst Reese <[email protected]>

ghstack-source-id: bfaaf6b323dfe87e3d63de0540260b3b122db6eb
Pull Request resolved: #442
@amyreese amyreese deleted the gh/amyreese/2/head branch April 20, 2024 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants