feat: add fixit lsp subcommand
#390
Conversation
facebook-github-bot
added
the
CLA Signed
llllvvuu
force-pushed
the
feat/lsp
branch
2 times, most recently
from
70ad9f7 to
d4b6989
Compare
llllvvuu
changed the title
fixit lsp subcommand
llllvvuu
force-pushed
the
feat/lsp
branch
7 times, most recently
from
2551e15 to
1d748d8
Compare
|
Sorry for the delay. I'll try to review this and your other PR's some time next week. |
There was a problem hiding this comment.
Sorry for the delay in reviewing this, and I really appreciate your time in putting this together. My only experience with writing an LSP is using the vscode templates, so forgive me if some of this goes against common patterns. I'm mostly interested in keeping the code more readable and maintainable, and I had a bit of difficulty following what was happening here. 😅
I don't want to impose on your time too much, so just let me know if you'd rather me be the one to adopt these suggestions, and I'll make sure to keep you as the primary author on the PR.
Cheers!
|
No worries, might be delayed as I don't have Wi-fi this month, but I'm happy to make the changes as they all seem sensible! |
llllvvuu
force-pushed
the
feat/lsp
branch
3 times, most recently
from
d3f16a3 to
6c79b05
Compare
|
Updated, sorry for the delay! |
llllvvuu
force-pushed
the
feat/lsp
branch
5 times, most recently
from
7fdf353 to
9dcd1ec
Compare
|
This is cool! Hope it will get merged 🤞 |
Support for: - [x] `textDocument/didOpen`, `textDocument/didChange` -> `textDocument/publishDiagnostics` - [x] `textDocument/formatting` No support yet: - [ ] `textDocument/codeAction`, `workspace/executeCommand` - [ ] `workspace/didChangeWatchedFiles` to invalidate the config cache test: Added new smoke test for the new `fixit lsp` subcommand.
|
Thank you for contributing this work and for responding to feedback. Look forward to this being in a future release! |
resolves #387 #122
Note: easier to read in unified view since it's new code.
Note: uses the popular pygls (Apache 2.0) implementation of the protocol.
demo.mp4
Summary
Support for:
textDocument/didOpen,textDocument/didChange->textDocument/publishDiagnosticstextDocument/formattingNot supported yet
textDocument/codeAction,workspace/executeCommand(possibly blocked on Automatic #lint-fixme suppressions #352 Better story around lint rules modifying imports #358)workspace/didChangeWatchedFilesto invalidate the config cacheIf this PR gets merged I will create follow-up issues for these items.
Test Plan
Added new smoke test for the new
fixit lspsubcommand.