Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[config] add use_noqa and defaults to False #151

Merged
merged 2 commits into from
Oct 23, 2020
Merged

[config] add use_noqa and defaults to False #151

merged 2 commits into from
Oct 23, 2020

Conversation

jimmylai
Copy link
Contributor

Summary

Add use_noqa and defaults to False

Test Plan

tox -e py38

@jimmylai jimmylai requested review from zsol, Kronuz and luciawlli October 23, 2020 18:01
Kronuz
Kronuz approved these changes Oct 23, 2020
View reviewed changes
Copy link
Contributor

@Kronuz Kronuz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 23, 2020
@jimmylai jimmylai merged commit 1d1cfe9 into Instagram:master Oct 23, 2020
@lisroach lisroach mentioned this pull request Apr 30, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kronuz Kronuz Kronuz approved these changes

@zsol zsol Awaiting requested review from zsol

@luciawlli luciawlli Awaiting requested review from luciawlli

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jimmylai @Kronuz @facebook-github-bot